From: Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
To: "Grover, Andrew" <andrew.grover-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: ACPI global lock macros
Date: Tue, 09 Dec 2003 11:04:05 -0800 [thread overview]
Message-ID: <3FD61CA5.6050203@google.com> (raw)
In-Reply-To: <F760B14C9561B941B89469F59BA3A8470255EFB3-sBd4vmA9Se4Lll3ZsUKC9FDQ4js95KgL@public.gmane.org>
Grover, Andrew wrote:
>
> BTW, i386, x86_64 and ia64 all have this macro, so these all might need
> to be looked at.
>
Yes, it was the differences between the i386 and x86_64 versions that
made me notice this problem. The ia64 version is in C, so looks safer.
Ideally there would be a common C definition - the only arch-specific
part should be the locked cmpxchg, unless this lock is likely to be
taken/released so often that it's performance critical.
Paul
-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive? Does it
help you create better code? SHARE THE LOVE, and help us help
YOU! Click Here: http://sourceforge.net/donate/
WARNING: multiple messages have this Message-ID (diff)
From: Paul Menage <menage@google.com>
To: "Grover, Andrew" <andrew.grover@intel.com>
Cc: linux-kernel@vger.kernel.org, acpi-devel@lists.sourceforge.net
Subject: Re: [ACPI] ACPI global lock macros
Date: Tue, 09 Dec 2003 11:04:05 -0800 [thread overview]
Message-ID: <3FD61CA5.6050203@google.com> (raw)
In-Reply-To: <F760B14C9561B941B89469F59BA3A8470255EFB3@orsmsx401.jf.intel.com>
Grover, Andrew wrote:
>
> BTW, i386, x86_64 and ia64 all have this macro, so these all might need
> to be looked at.
>
Yes, it was the differences between the i386 and x86_64 versions that
made me notice this problem. The ia64 version is in C, so looks safer.
Ideally there would be a common C definition - the only arch-specific
part should be the locked cmpxchg, unless this lock is likely to be
taken/released so often that it's performance critical.
Paul
next prev parent reply other threads:[~2003-12-09 19:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-09 18:20 [ACPI] ACPI global lock macros Grover, Andrew
2003-12-09 18:20 ` Grover, Andrew
[not found] ` <F760B14C9561B941B89469F59BA3A8470255EFB3-sBd4vmA9Se4Lll3ZsUKC9FDQ4js95KgL@public.gmane.org>
2003-12-09 19:04 ` Paul Menage [this message]
2003-12-09 19:04 ` Paul Menage
2003-12-09 19:03 ` David Mosberger
-- strict thread matches above, loose matches on Subject: below --
2003-12-11 7:27 Yu, Luming
[not found] ` <3ACA40606221794F80A5670F0AF15F8401720C22-SRlDPOYGfgogGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2003-12-11 17:46 ` Nate Lawson
2003-12-11 7:06 Yu, Luming
2003-12-11 8:07 ` [ACPI] " Andi Kleen
[not found] ` <20031211090716.0c3662d3.ak-l3A5Bk7waGM@public.gmane.org>
2003-12-11 8:27 ` Paul Menage
[not found] ` <3ACA40606221794F80A5670F0AF15F8401720C21-SRlDPOYGfgogGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2003-12-11 8:20 ` Paul Menage
2003-12-09 9:22 Paul Menage
2003-12-09 9:22 ` Paul Menage
[not found] ` <3FD59441.2000202-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2003-12-09 9:36 ` Arjan van de Ven
2003-12-09 9:36 ` Arjan van de Ven
[not found] ` <1070962573.5223.2.camel-PDvaWZGbcxi0rsOeZxrteAC/G2K4zDHf@public.gmane.org>
2003-12-09 9:42 ` Paul Menage
2003-12-09 9:42 ` Paul Menage
[not found] ` <3FD5990A.9020908-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2003-12-09 9:43 ` Arjan van de Ven
2003-12-09 9:43 ` Arjan van de Ven
[not found] ` <20031209094356.GA19702-s/M1imWmeEoQw3kMeb7FcACJwEvxM/w9@public.gmane.org>
2003-12-09 9:50 ` Paul Menage
2003-12-09 9:50 ` Paul Menage
2003-12-10 7:45 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FD61CA5.6050203@google.com \
--to=menage-hpiqsd4aklfqt0dzr+alfa@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=andrew.grover-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.