* [uml-devel] [PATCH] hostaudio fails to build as a module
@ 2003-12-16 22:26 Matt Zimmerman
2003-12-16 22:49 ` [uml-devel] " Matt Zimmerman
0 siblings, 1 reply; 3+ messages in thread
From: Matt Zimmerman @ 2003-12-16 22:26 UTC (permalink / raw)
To: user-mode-linux-devel
[-- Attachment #1: Type: text/plain, Size: 126 bytes --]
DSP_HELP and MIXER_HELP are undefined when MODULE is defined. This patch
just moves them out of the conditional.
--
- mdz
[-- Attachment #2: hostaudio-module.diff --]
[-- Type: text/plain, Size: 1249 bytes --]
--- kernel-source-2.4.22/arch/um/drivers/hostaudio_kern.c.orig 2003-12-16 14:23:31.000000000 -0800
+++ kernel-source-2.4.22/arch/um/drivers/hostaudio_kern.c 2003-12-16 14:24:02.000000000 -0800
@@ -20,6 +20,14 @@
char *dsp = HOSTAUDIO_DEV_DSP;
char *mixer = HOSTAUDIO_DEV_MIXER;
+#define DSP_HELP \
+" This is used to specify the host dsp device to the hostaudio driver.\n" \
+" The default is \"" HOSTAUDIO_DEV_DSP "\".\n\n"
+
+#define MIXER_HELP \
+" This is used to specify the host mixer device to the hostaudio driver.\n" \
+" The default is \"" HOSTAUDIO_DEV_MIXER "\".\n\n"
+
#ifndef MODULE
static int set_dsp(char *name, int *add)
{
@@ -27,10 +35,6 @@
return(0);
}
-#define DSP_HELP \
-" This is used to specify the host dsp device to the hostaudio driver.\n" \
-" The default is \"" HOSTAUDIO_DEV_DSP "\".\n\n"
-
__uml_setup("dsp=", set_dsp, "dsp=<dsp device>\n" DSP_HELP);
static int set_mixer(char *name, int *add)
@@ -39,10 +43,6 @@
return(0);
}
-#define MIXER_HELP \
-" This is used to specify the host mixer device to the hostaudio driver.\n" \
-" The default is \"" HOSTAUDIO_DEV_MIXER "\".\n\n"
-
__uml_setup("mixer=", set_mixer, "mixer=<mixer device>\n" MIXER_HELP);
#else /*MODULE*/
^ permalink raw reply [flat|nested] 3+ messages in thread* [uml-devel] Re: [PATCH] hostaudio fails to build as a module 2003-12-16 22:26 [uml-devel] [PATCH] hostaudio fails to build as a module Matt Zimmerman @ 2003-12-16 22:49 ` Matt Zimmerman 2003-12-16 23:38 ` Jeff Dike 0 siblings, 1 reply; 3+ messages in thread From: Matt Zimmerman @ 2003-12-16 22:49 UTC (permalink / raw) To: user-mode-linux-devel On Tue, Dec 16, 2003 at 02:26:07PM -0800, Matt Zimmerman wrote: > DSP_HELP and MIXER_HELP are undefined when MODULE is defined. This patch > just moves them out of the conditional. I hadn't yet received the 2.4.22-7 release announcement when I sent this; looks like this change is already in there. -- - mdz ------------------------------------------------------- This SF.net email is sponsored by: IBM Linux Tutorials. Become an expert in LINUX or just sharpen your skills. Sign up for IBM's Free Linux Tutorials. Learn everything from the bash shell to sys admin. Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [uml-devel] Re: [PATCH] hostaudio fails to build as a module 2003-12-16 22:49 ` [uml-devel] " Matt Zimmerman @ 2003-12-16 23:38 ` Jeff Dike 0 siblings, 0 replies; 3+ messages in thread From: Jeff Dike @ 2003-12-16 23:38 UTC (permalink / raw) To: Matt Zimmerman; +Cc: user-mode-linux-devel > I hadn't yet received the 2.4.22-7 release announcement when I sent > this; looks like this change is already in there. Yup, I fixed it pretty soon after I released -6. Jeff ------------------------------------------------------- This SF.net email is sponsored by: IBM Linux Tutorials. Become an expert in LINUX or just sharpen your skills. Sign up for IBM's Free Linux Tutorials. Learn everything from the bash shell to sys admin. Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-12-16 23:23 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2003-12-16 22:26 [uml-devel] [PATCH] hostaudio fails to build as a module Matt Zimmerman 2003-12-16 22:49 ` [uml-devel] " Matt Zimmerman 2003-12-16 23:38 ` Jeff Dike
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.