All of lore.kernel.org
 help / color / mirror / Atom feed
* [BUG] 2.6.0: ARM won't build without CONFIG_CPU_FREQ_GOV_USERSPACE=y
@ 2003-12-25 16:00 Russell King
  0 siblings, 0 replies; 4+ messages in thread
From: Russell King @ 2003-12-25 16:00 UTC (permalink / raw)
  To: cpufreq

Hi,

Trying to build ARM for assabet with 2.6.0, CONFIG_CPU_FREQ_GOV_USERSPACE
unset or as a module causes the following errors:

cpufreq_get() is rather central to ARM support since several drivers,
including SDRAM drivers need to know the CPU core clock rate in other
to function.

We therefore can not have this function in a module.

arch/arm/mach-sa1100/built-in.o(.init.text+0x32c): In function `sa1110_clk_init':
: undefined reference to `cpufreq_gov_userspace_init'
drivers/built-in.o(.text+0x3e1fc): In function `sa1100fb_check_var':
: undefined reference to `cpufreq_get'
drivers/built-in.o(.text+0x3e524): In function `sa1100fb_activate_var':
: undefined reference to `cpufreq_get'
drivers/built-in.o(.text+0x4fe84): In function `sa1100_pcmcia_set_io_map':
: undefined reference to `cpufreq_get'
drivers/built-in.o(.text+0x4ff74): In function `sa1100_pcmcia_set_mem_map':
: undefined reference to `cpufreq_get'
drivers/built-in.o(.text+0x5006c): In function `show_status':
: undefined reference to `cpufreq_get'
drivers/built-in.o(.text+0x50540): more undefined references to `cpufreq_get' follow
make[1]: *** [.tmp_vmlinux1] Error 1
make: *** [zImage] Error 2

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [BUG] 2.6.0: ARM won't build without CONFIG_CPU_FREQ_GOV_USERSPACE=y
@ 2003-12-26  9:57 linux
  2003-12-26 10:25 ` Russell King
  0 siblings, 1 reply; 4+ messages in thread
From: linux @ 2003-12-26  9:57 UTC (permalink / raw)
  To: cpufreq, rmk

Because of "cpufreq_get()" being necessary for SA1100 it is already
special-handled for this architecture. 

A snippet from arch/arm/Kconfig:

# CPUfreq on SA11x0 is special -- it _needs_ the userspace governor

config CPU_FREQ_SA1100
	bool
	depends on CPU_FREQ && SA1100_LART
	default y
	select CPU_FREQ_DEFAULT_GOV_USERSPACE
	select CPU_FREQ_24_API if SYSCTL

config CPU_FREQ_SA1110
	bool
	depends on CPU_FREQ && (SA1100_ASSABET || SA1100_CERF |
SA1100_PT_SYSTEM3)
	default y
	select CPU_FREQ_DEFAULT_GOV_USERSPACE
	select CPU_FREQ_24_API if SYSCTL


IMO this should cause the default governor to be forced to "userspace",
and the deprecated 2.4. API [including cpufreq_get()] to be activated as
well. However, Kconfig thinks different: the default setting for
CPU_FREQ_DEFAULT_GOV (see drivers/cpufreq/Kconfig) is PERFORMANCE, and
this seems to take precedence over the "select". IMHO this is a Kconfig
bug -- can you notify the maintainer of this issue, please?

Else we'd have to change drivers/cpufreq/Kconfig from
default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
to
default CPU_FREQ_DEFAULT_GOV_PERFORMANCE if !CPU_FREQ_SA1100
default CPU_FREQ_DEFAULT_GOV_USERSPACE if !CPU_FREQ_SA1100
or disable the selection for CPU_FREQ_SA1100 completely.

    Dominik

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-12-28 21:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-12-25 16:00 [BUG] 2.6.0: ARM won't build without CONFIG_CPU_FREQ_GOV_USERSPACE=y Russell King
  -- strict thread matches above, loose matches on Subject: below --
2003-12-26  9:57 linux
2003-12-26 10:25 ` Russell King
2003-12-28 21:51   ` Dominik Brodowski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.