From: "David S. Miller" <davem@redhat.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH] pci_set_dac helper
Date: Wed, 31 Dec 2003 10:37:05 -0800 [thread overview]
Message-ID: <20031231103705.238ba07d.davem@redhat.com> (raw)
In-Reply-To: <3FF2F57A.80801@pobox.com>
On Wed, 31 Dec 2003 11:12:42 -0500
Jeff Garzik <jgarzik@pobox.com> wrote:
> It seems to me like a lot of drivers wind up getting their
> pci_set_dma_mask stuff wrong, occasionally in subtle ways. So, I
> created a "give me 64-bit PCI DMA" helper function.
>
> The attached patch demonstrates its use in tg3, from which the logic
> originated. It also fixes a tiny bug in tg3, whereby it might return
> zero on error (rather than -EFOO) if the pci_set_dma_mask succeeds but
> pci_set_consistent_dma_mask fails.
I'm fine with the helper.
The tg3 error return bug you noticed is already fixed in the tg3
updates I'm sending to Linus today.
next prev parent reply other threads:[~2003-12-31 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-31 16:12 [PATCH] pci_set_dac helper Jeff Garzik
2003-12-31 18:37 ` David S. Miller [this message]
2003-12-31 18:59 ` Matthew Wilcox
2003-12-31 19:05 ` Jeff Garzik
2004-01-01 3:03 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031231103705.238ba07d.davem@redhat.com \
--to=davem@redhat.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.