From: Grant Grundler <grundler@parisc-linux.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Matthew Wilcox <willy@debian.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@redhat.com>,
Andrew Morton <akpm@osdl.org>,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH] pci_set_dac helper
Date: Wed, 31 Dec 2003 20:03:22 -0700 [thread overview]
Message-ID: <20040101030322.GA6516@colo.lackof.org> (raw)
In-Reply-To: <3FF31DFB.9030907@pobox.com>
On Wed, Dec 31, 2003 at 02:05:31PM -0500, Jeff Garzik wrote:
> Matthew Wilcox wrote:
> > I note that both this and your patch will lead to two errors being
> > printed on 64-bit consistent failure; one by tg3 and one by the PCI
> > layer; this seems suboptimal. I suspect you want to do away with the
> > error printk in the tg3 driver.
>
> That was intentional in my patch, as it's a warning not an error in my
> pci_set_dac. In your version I would agree.
It's perfectly ok for some platforms to not support 64-bit DMA mask
for either type of DMA. The warning suggests it's not OK.
I don't see why we either a warning or error printed unless it would
lead to incorrect operation of the device.
grant
prev parent reply other threads:[~2004-01-01 3:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-31 16:12 [PATCH] pci_set_dac helper Jeff Garzik
2003-12-31 18:37 ` David S. Miller
2003-12-31 18:59 ` Matthew Wilcox
2003-12-31 19:05 ` Jeff Garzik
2004-01-01 3:03 ` Grant Grundler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040101030322.GA6516@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.