All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/8] ARM: digicolor: add minimal device tree description
Date: Thu, 08 Jan 2015 23:41:52 +0100	[thread overview]
Message-ID: <20032538.pHVo39OjvN@wuerfel> (raw)
In-Reply-To: <9d8d7aed6220e9e92ab70217a65d3291924cfa71.1420744369.git.baruch@tkos.co.il>

On Thursday 08 January 2015 21:39:59 Baruch Siach wrote:
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200 earlyprintk";
> +	};
> +};

Please don't put earlyprintk into the dtb. Hopefully by the next
merge window we will have working earlycon support as a replacement.
You can already put an stdout-path property into the chosen node
for this.

> +	interrupt-parent = <&intc>;
> +
> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +		serial2 = &uart2;
> +	};

Better move the aliases into the board specific file.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 3/8] ARM: digicolor: add minimal device tree description
Date: Thu, 08 Jan 2015 23:41:52 +0100	[thread overview]
Message-ID: <20032538.pHVo39OjvN@wuerfel> (raw)
In-Reply-To: <9d8d7aed6220e9e92ab70217a65d3291924cfa71.1420744369.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>

On Thursday 08 January 2015 21:39:59 Baruch Siach wrote:
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200 earlyprintk";
> +	};
> +};

Please don't put earlyprintk into the dtb. Hopefully by the next
merge window we will have working earlycon support as a replacement.
You can already put an stdout-path property into the chosen node
for this.

> +	interrupt-parent = <&intc>;
> +
> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +		serial2 = &uart2;
> +	};

Better move the aliases into the board specific file.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Baruch Siach <baruch@tkos.co.il>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	devicetree@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/8] ARM: digicolor: add minimal device tree description
Date: Thu, 08 Jan 2015 23:41:52 +0100	[thread overview]
Message-ID: <20032538.pHVo39OjvN@wuerfel> (raw)
In-Reply-To: <9d8d7aed6220e9e92ab70217a65d3291924cfa71.1420744369.git.baruch@tkos.co.il>

On Thursday 08 January 2015 21:39:59 Baruch Siach wrote:
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200 earlyprintk";
> +	};
> +};

Please don't put earlyprintk into the dtb. Hopefully by the next
merge window we will have working earlycon support as a replacement.
You can already put an stdout-path property into the chosen node
for this.

> +	interrupt-parent = <&intc>;
> +
> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +		serial2 = &uart2;
> +	};

Better move the aliases into the board specific file.

	Arnd

  reply	other threads:[~2015-01-08 22:41 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 19:39 [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support Baruch Siach
2015-01-08 19:39 ` Baruch Siach
2015-01-08 19:39 ` Baruch Siach
2015-01-08 19:39 ` [PATCH v2 1/8] ARM: initial support for Conexant Digicolor CX92755 SoC Baruch Siach
2015-01-08 19:39   ` Baruch Siach
2015-01-08 19:39 ` [PATCH v2 2/8] ARM: digicolor: add low level debug support Baruch Siach
2015-01-08 19:39   ` Baruch Siach
2015-01-08 19:39 ` [PATCH v2 3/8] ARM: digicolor: add minimal device tree description Baruch Siach
2015-01-08 19:39   ` Baruch Siach
2015-01-08 22:41   ` Arnd Bergmann [this message]
2015-01-08 22:41     ` Arnd Bergmann
2015-01-08 22:41     ` Arnd Bergmann
2015-01-09 11:46   ` Mark Rutland
2015-01-09 11:46     ` Mark Rutland
2015-01-09 11:46     ` Mark Rutland
2015-01-11  9:38     ` Baruch Siach
2015-01-11  9:38       ` Baruch Siach
2015-01-11  9:38       ` Baruch Siach
2015-01-08 19:40 ` [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding Baruch Siach
2015-01-08 19:40   ` Baruch Siach
2015-01-09 11:50   ` Mark Rutland
2015-01-09 11:50     ` Mark Rutland
2015-01-09 11:50     ` Mark Rutland
2015-01-11 11:21     ` Baruch Siach
2015-01-11 11:21       ` Baruch Siach
2015-01-09 15:12   ` Sergei Shtylyov
2015-01-09 15:12     ` Sergei Shtylyov
2015-01-11 11:29     ` Baruch Siach
2015-01-11 11:29       ` Baruch Siach
2015-01-08 19:40 ` [PATCH v2 5/8] irqchip: Conexant CX92755 interrupts controller driver Baruch Siach
2015-01-08 19:40   ` Baruch Siach
2015-01-08 19:40 ` [PATCH v2 6/8] clocksource: devicetree: document Conexant Digicolor timer binding Baruch Siach
2015-01-08 19:40   ` Baruch Siach
2015-01-08 19:40 ` [PATCH v2 7/8] clocksource: driver for Conexant Digicolor SoC timer Baruch Siach
2015-01-08 19:40   ` Baruch Siach
2015-01-08 19:40 ` [PATCH v2 8/8] ARM: devicetree: document supported Conexant Digicolor SoC Baruch Siach
2015-01-08 19:40   ` Baruch Siach
2015-01-08 22:46 ` [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support Arnd Bergmann
2015-01-08 22:46   ` Arnd Bergmann
2015-01-08 22:46   ` Arnd Bergmann
2015-01-11 11:33   ` Baruch Siach
2015-01-11 11:33     ` Baruch Siach
2015-01-11 15:49     ` Arnd Bergmann
2015-01-11 15:49       ` Arnd Bergmann
2015-01-11 15:49       ` Arnd Bergmann
2015-01-28 22:33   ` Paul Bolle
2015-01-28 22:33     ` Paul Bolle
2015-01-28 22:33     ` Paul Bolle
2015-01-28 22:41     ` Baruch Siach
2015-01-28 22:41       ` Baruch Siach
2015-01-28 22:41       ` Baruch Siach
2015-01-28 22:52       ` Paul Bolle
2015-01-28 22:52         ` Paul Bolle
2015-01-28 22:52         ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20032538.pHVo39OjvN@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.