From: Christoph Hellwig <hch@lst.de>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: Andrew Morton <akpm@osdl.org>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs-private data in struct block_device
Date: Fri, 2 Jan 2004 00:32:27 +0100 [thread overview]
Message-ID: <20040101233226.GA5286@lst.de> (raw)
In-Reply-To: <20040101232832.GS4176@parcelfarce.linux.theplanet.co.uk>
On Thu, Jan 01, 2004 at 11:28:32PM +0000, viro@parcelfarce.linux.theplanet.co.uk wrote:
> > Okay, let's make it more general. Throw the filesystem completly out of
> > the few and say the private data can be used by the owner of that
> > blockdevice as established by bd_claim, okay?
>
> OK... One question: what rules do you want wrt multiple claims with the
> same owner?
I'd say this is the owners problem and add a big comment about that.
What about something like the version below?:
--- 1.276/include/linux/fs.h Mon Dec 29 22:37:20 2003
+++ edited/include/linux/fs.h Fri Jan 2 01:30:42 2004
@@ -353,6 +353,13 @@
int bd_invalidated;
struct gendisk * bd_disk;
struct list_head bd_list;
+ /*
+ * Private data. You must have bd_claimed the block_device
+ * to use this. NOTE: bd_claims allows an owner to claim
+ * the same device multiple timers, the owner must take special
+ * care to not mess up bd_private for that case.
+ */
+ unsigned long bd_private;
};
/*
next prev parent reply other threads:[~2004-01-01 23:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-01 16:42 [PATCH] fs-private data in struct block_device Christoph Hellwig
2004-01-01 23:10 ` Andrew Morton
2004-01-01 23:21 ` viro
2004-01-01 23:23 ` Christoph Hellwig
2004-01-01 23:28 ` viro
2004-01-01 23:32 ` Christoph Hellwig [this message]
2004-01-04 22:04 ` Randy.Dunlap
2004-01-01 23:22 ` Christoph Hellwig
2004-01-02 2:43 ` Jeff Garzik
2004-01-02 8:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040101233226.GA5286@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.