All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Christoph Hellwig <hch@lst.de>,
	viro@parcelfarce.linux.theplanet.co.uk,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs-private data in struct block_device
Date: Thu, 1 Jan 2004 21:43:17 -0500	[thread overview]
Message-ID: <20040102024317.GA3851@gtf.org> (raw)
In-Reply-To: <20040101151017.3f7bc407.akpm@osdl.org>

On Thu, Jan 01, 2004 at 03:10:17PM -0800, Andrew Morton wrote:
> > --- 1.276/include/linux/fs.h	Mon Dec 29 22:37:20 2003
> > +++ edited/include/linux/fs.h	Thu Jan  1 13:42:08 2004
> > @@ -353,6 +353,7 @@
> >  	int			bd_invalidated;
> >  	struct gendisk *	bd_disk;
> >  	struct list_head	bd_list;
> > +	unsigned long		bd_fspriv; /* file-system private data */
> >  };
> >  
> >  /*
> 
> Seems sane.  You'll need to decide whether that field should be operated
> upon with atomic ops.  If so, document it.  If not, document its locking,
> please.

It looks like the standard normally-a-pointer thing that's completely
managed opaquely to the block device layer.  In fact, I actually prefer
that these be (void*) unless there is a common use as an integer.

	Jeff




  parent reply	other threads:[~2004-01-02  2:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-01 16:42 [PATCH] fs-private data in struct block_device Christoph Hellwig
2004-01-01 23:10 ` Andrew Morton
2004-01-01 23:21   ` viro
2004-01-01 23:23     ` Christoph Hellwig
2004-01-01 23:28       ` viro
2004-01-01 23:32         ` Christoph Hellwig
2004-01-04 22:04           ` Randy.Dunlap
2004-01-01 23:22   ` Christoph Hellwig
2004-01-02  2:43   ` Jeff Garzik [this message]
2004-01-02  8:48     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040102024317.GA3851@gtf.org \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.