* s3 sleep: Kill obsolete debugging code
@ 2004-01-02 22:46 Pavel Machek
2004-01-07 23:51 ` Rusty Russell
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2004-01-02 22:46 UTC (permalink / raw)
To: kernel list, Rusty trivial patch monkey Russell, Andrew Morton,
Patrick Mochel
Hi!
wakeup.S includes some rather nasty, and unneccessary debugging
code. (It used to try to flush caches/tlbs; now its totally
useless). Please apply,
Pavel
Index: linux.new/arch/i386/kernel/acpi/wakeup.S
===================================================================
--- linux.new.orig/arch/i386/kernel/acpi/wakeup.S 2003-12-25 13:28:50.000000000 +0100
+++ linux.new/arch/i386/kernel/acpi/wakeup.S 2003-12-25 13:29:06.000000000 +0100
@@ -193,11 +193,6 @@
# and restore the stack ... but you need gdt for this to work
movl saved_context_esp, %esp
- movw $0x0e00 + 'W', 0xb8018
- outl %eax, $0x80
- outl %eax, $0x80
- movw $0x0e00 + 'O', 0xb8018
-
movl %cs:saved_magic, %eax
cmpl $0x12345678, %eax
jne bogus_magic
@@ -205,9 +200,6 @@
# jump to place where we left off
movl saved_eip,%eax
movw $0x0e00 + 'x', 0xb8018
- outl %eax, $0x80
- outl %eax, $0x80
- movw $0x0e00 + '!', 0xb801a
jmp *%eax
bogus_magic:
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: s3 sleep: Kill obsolete debugging code
2004-01-02 22:46 s3 sleep: Kill obsolete debugging code Pavel Machek
@ 2004-01-07 23:51 ` Rusty Russell
2004-01-08 12:00 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Rusty Russell @ 2004-01-07 23:51 UTC (permalink / raw)
To: Pavel Machek; +Cc: kernel list, Andrew Morton, Patrick Mochel
In message <20040102224644.GA466@elf.ucw.cz> you write:
> Hi!
>
> wakeup.S includes some rather nasty, and unneccessary debugging
> code. (It used to try to flush caches/tlbs; now its totally
> useless). Please apply,
> Pavel
Removing asm not really trivial unless the author sent it...
Sorry,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: s3 sleep: Kill obsolete debugging code
2004-01-07 23:51 ` Rusty Russell
@ 2004-01-08 12:00 ` Pavel Machek
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2004-01-08 12:00 UTC (permalink / raw)
To: Rusty Russell; +Cc: kernel list, Andrew Morton, Patrick Mochel
Hi!
> > wakeup.S includes some rather nasty, and unneccessary debugging
> > code. (It used to try to flush caches/tlbs; now its totally
> > useless). Please apply,
> > Pavel
>
> Removing asm not really trivial unless the author sent it...
I was author of original debugging code, than Patrick simplified it,
and by now its totaly useless. Anyway it seems that Andrew took the
patch, so it is on its way to linus.
Pavel
--
Horseback riding is like software...
...vgf orggre jura vgf serr.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-01-08 12:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-02 22:46 s3 sleep: Kill obsolete debugging code Pavel Machek
2004-01-07 23:51 ` Rusty Russell
2004-01-08 12:00 ` Pavel Machek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.