From: Stefan Rompf <srompf@isg.de>
To: Michal Ostrowski <mostrows@watson.ibm.com>, netdev@oss.sgi.com
Subject: Re: Deadlock in sungem/ip_auto_config/linkwatch
Date: Mon, 5 Jan 2004 15:50:50 +0100 [thread overview]
Message-ID: <200401051550.51063.srompf@isg.de> (raw)
In-Reply-To: <1073307882.2041.98320.camel@brick.watson.ibm.com>
Am Montag, 05. Januar 2004 14:07 schrieb Michal Ostrowski:
> ic_open_devs grabs rtnl_sem with an rtnl_shlock() call.
>
> The sungem driver at some point calls gem_init_one, which calls
> netif_carrier_*, which in turn calls schedule_work (linkwatch_event).
>
> linkwatch_event in turn needs rtnl_sem.
Good catch! The sungem driver shows clearly that we need some way to remove
queued work without scheduling and waiting for other events.
I will change the linkwatch code to use rtnl_shlock_nowait() and backoff and
retry in case of failure this week. Call it a workaround, but it increases
overall system stability.
Btw, what is the planned difference between rtnl_shlock() and rtnl_exlock()?
Even though the later is a null operation right now, I don't want to hold
more locks than needed in the linkwatch code.
Stefan
--
"doesn't work" is not a magic word to explain everything.
next prev parent reply other threads:[~2004-01-05 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-05 13:07 Deadlock in sungem/ip_auto_config/linkwatch Michal Ostrowski
2004-01-05 14:50 ` Stefan Rompf [this message]
2004-01-05 16:19 ` Michal Ostrowski
2004-01-05 16:50 ` Stefan Rompf
2004-01-05 19:02 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200401051550.51063.srompf@isg.de \
--to=srompf@isg.de \
--cc=mostrows@watson.ibm.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.