All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: 2.6.1-rc2-mm1: drm/sis_mm.c compile error
Date: Thu, 8 Jan 2004 10:34:04 -0800	[thread overview]
Message-ID: <20040108103404.1a90d34f.akpm@osdl.org> (raw)
In-Reply-To: <20040108153656.GF13867@fs.tum.de>

Adrian Bunk <bunk@fs.tum.de> wrote:
>
> drivers/char/drm/sis_mm.c:37:25: linux/sisfb.h: No such file or directory
>  drivers/char/drm/sis_mm.c: In function `sis_fb_alloc':
>  drivers/char/drm/sis_mm.c:92: error: storage size of `req' isn't known
>  drivers/char/drm/sis_mm.c:98: warning: implicit declaration of function `sis_malloc'
>  drivers/char/drm/sis_mm.c:105: warning: implicit declaration of function `sis_free'
>  drivers/char/drm/sis_mm.c:92: warning: unused variable `req'

Yes.  The video header files were moved.  I assume this code is also
designed to build under 2.4.  If so, something like this is the way to go:

---

 drivers/char/drm/sis_mm.c |    4 ++++
 1 files changed, 4 insertions(+)

diff -puN drivers/char/drm/sis_mm.c~drm-include-fix drivers/char/drm/sis_mm.c
--- 25/drivers/char/drm/sis_mm.c~drm-include-fix	2004-01-08 10:14:41.000000000 -0800
+++ 25-akpm/drivers/char/drm/sis_mm.c	2004-01-08 10:16:49.000000000 -0800
@@ -34,8 +34,12 @@
 #include "sis_drv.h"
 #include "sis_ds.h"
 #if defined(__linux__) && defined(CONFIG_FB_SIS)
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)
+#include <video/sisfb.h>
+#else
 #include <linux/sisfb.h>
 #endif
+#endif
 
 #define MAX_CONTEXT 100
 #define VIDEO_TYPE 0 

_


  reply	other threads:[~2004-01-08 18:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-08  7:28 2.6.1-rc2-mm1 Andrew Morton
2004-01-08  7:28 ` 2.6.1-rc2-mm1 Andrew Morton
2004-01-08  8:20 ` 2.6.1-rc2-mm1 Andrew Morton
2004-01-08  8:20   ` 2.6.1-rc2-mm1 Andrew Morton
2004-01-08 11:00 ` 2.6.1-rc2-mm1 Daniel Drake
2004-01-08 13:01 ` 2.6.1-rc2-mm1 Ramon Rey Vicente
2004-01-08 18:11   ` 2.6.1-rc2-mm1 Andrew Morton
2004-01-08 18:11     ` 2.6.1-rc2-mm1 Andrew Morton
2004-01-09  8:35     ` 2.6.1-rc2-mm1 Philipp Matthias Hahn
2004-01-09  8:51       ` 2.6.1-rc2-mm1 Jens Axboe
2004-01-08 15:36 ` 2.6.1-rc2-mm1: drm/sis_mm.c compile error Adrian Bunk
2004-01-08 18:34   ` Andrew Morton [this message]
2004-01-08 23:54   ` [Dri-devel] " Alan Cox
2004-01-08 20:22 ` 2.6.1-rc2-mm1 Torrey Hoffman
2004-01-08 20:22   ` 2.6.1-rc2-mm1 Torrey Hoffman
2004-01-08 20:46   ` 2.6.1-rc2-mm1 Torrey Hoffman
2004-01-08 20:46     ` 2.6.1-rc2-mm1 Torrey Hoffman
2004-01-08 20:50     ` 2.6.1-rc2-mm1 Andrew Morton
2004-01-08 20:50       ` 2.6.1-rc2-mm1 Andrew Morton
2004-01-08 20:46   ` 2.6.1-rc2-mm1 Torrey Hoffman
2004-01-08 20:46     ` 2.6.1-rc2-mm1 Torrey Hoffman
2004-01-09  1:06     ` 2.6.1-rc2-mm1 Roberto Sanchez
2004-01-09  1:14       ` 2.6.1-rc2-mm1 Robert Love
2004-01-09  1:14         ` 2.6.1-rc2-mm1 Robert Love
2004-01-09  1:52 ` [patch] 2.6.1-rc2-mm1: qla1280.c doesn't compile Adrian Bunk
2004-01-09 13:49   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040108103404.1a90d34f.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=bunk@fs.tum.de \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.