From: Christoph Hellwig <hch@infradead.org>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Andrew Morton <akpm@osdl.org>,
Jes Sorensen <jes@trained-monkey.org>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [patch] 2.6.1-rc2-mm1: qla1280.c doesn't compile
Date: Fri, 9 Jan 2004 13:49:42 +0000 [thread overview]
Message-ID: <20040109134942.A24302@infradead.org> (raw)
In-Reply-To: <20040109015229.GK13867@fs.tum.de>; from bunk@fs.tum.de on Fri, Jan 09, 2004 at 02:52:30AM +0100
On Fri, Jan 09, 2004 at 02:52:30AM +0100, Adrian Bunk wrote:
> I got the following compile error when trying to compile this driver
> statically into a kernel with hotplug enabled:
Jes, that's your ifdef-magic around around qla1280_remove_one.. Do you
remember why you added it? The only case we don't need it is when
the driver is builtin and CONFIG_HOTPLUG is not set - and in that case
__devexit should get rid of it for us.
> Since I don't see a good reason why qla1280_remove_one is #ifdef'ed out
> in the non-modular case the patch below fixes this problem by removing
> two #ifdef's.
The patch looks good to me. In fact that's how it was in the patch
I sent to Jes..
prev parent reply other threads:[~2004-01-09 13:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-08 7:28 2.6.1-rc2-mm1 Andrew Morton
2004-01-08 7:28 ` 2.6.1-rc2-mm1 Andrew Morton
2004-01-08 8:20 ` 2.6.1-rc2-mm1 Andrew Morton
2004-01-08 8:20 ` 2.6.1-rc2-mm1 Andrew Morton
2004-01-08 11:00 ` 2.6.1-rc2-mm1 Daniel Drake
2004-01-08 13:01 ` 2.6.1-rc2-mm1 Ramon Rey Vicente
2004-01-08 18:11 ` 2.6.1-rc2-mm1 Andrew Morton
2004-01-08 18:11 ` 2.6.1-rc2-mm1 Andrew Morton
2004-01-09 8:35 ` 2.6.1-rc2-mm1 Philipp Matthias Hahn
2004-01-09 8:51 ` 2.6.1-rc2-mm1 Jens Axboe
2004-01-08 15:36 ` 2.6.1-rc2-mm1: drm/sis_mm.c compile error Adrian Bunk
2004-01-08 18:34 ` Andrew Morton
2004-01-08 23:54 ` [Dri-devel] " Alan Cox
2004-01-08 20:22 ` 2.6.1-rc2-mm1 Torrey Hoffman
2004-01-08 20:22 ` 2.6.1-rc2-mm1 Torrey Hoffman
2004-01-08 20:46 ` 2.6.1-rc2-mm1 Torrey Hoffman
2004-01-08 20:46 ` 2.6.1-rc2-mm1 Torrey Hoffman
2004-01-08 20:50 ` 2.6.1-rc2-mm1 Andrew Morton
2004-01-08 20:50 ` 2.6.1-rc2-mm1 Andrew Morton
2004-01-08 20:46 ` 2.6.1-rc2-mm1 Torrey Hoffman
2004-01-08 20:46 ` 2.6.1-rc2-mm1 Torrey Hoffman
2004-01-09 1:06 ` 2.6.1-rc2-mm1 Roberto Sanchez
2004-01-09 1:14 ` 2.6.1-rc2-mm1 Robert Love
2004-01-09 1:14 ` 2.6.1-rc2-mm1 Robert Love
2004-01-09 1:52 ` [patch] 2.6.1-rc2-mm1: qla1280.c doesn't compile Adrian Bunk
2004-01-09 13:49 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040109134942.A24302@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=bunk@fs.tum.de \
--cc=jes@trained-monkey.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.