* [Kernel-janitors] [patch 2.6.1] double put_user in
@ 2004-01-16 17:53 Domen Puncer
0 siblings, 0 replies; only message in thread
From: Domen Puncer @ 2004-01-16 17:53 UTC (permalink / raw)
To: kernel-janitors
Hi.
Trivial, this patch was a bit wrong:
http://linux.bkbits.net:8080/linux-2.5/diffs/drivers/s390/net/ctctty.c@1.20
Also "if (error)" is not really needed; put_user returns 0 on success.
--- c/drivers/s390/net/ctctty.c 2003-12-18 03:58:56.000000000 +0100
+++ a/drivers/s390/net/ctctty.c 2004-01-16 18:47:34.000000000 +0100
@@ -759,10 +759,7 @@ ctc_tty_ioctl(struct tty_struct *tty, st
info->line);
#endif
error = put_user(C_CLOCAL(tty) ? 1 : 0, (ulong *) arg);
- if (error)
- return error;
- put_user(C_CLOCAL(tty) ? 1 : 0, (ulong *) arg);
- return 0;
+ return error;
case TIOCSSOFTCAR:
#ifdef CTC_DEBUG_MODEM_IOCTL
printk(KERN_DEBUG "%s%d ioctl TIOCSSOFTCAR\n", CTC_TTY_NAME,
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-01-16 17:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-16 17:53 [Kernel-janitors] [patch 2.6.1] double put_user in Domen Puncer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.