* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
@ 2004-01-12 4:43 ` Eugene Teo
2004-01-12 11:23 ` Domen Puncer
` (16 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: Eugene Teo @ 2004-01-12 4:43 UTC (permalink / raw)
To: kernel-janitors
Great. Nice colours, and layout too.
<quote sender="Randy.Dunlap">
>
> If you haven't already noticed it, the kernel janitors web page
> has moved to http://janitor.kernelnewbies.org .
>
> That web page tells you about KJ CVS, #irc, email, etc.
>
> --
> ~Randy
> MOTD: Always include version info.
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors
>
--
Eugene TEO <eugeneteo@eugeneteo.net> <http://www.anomalistic.org/>
1024D/14A0DDE5 print D851 4574 E357 469C D308 A01E 7321 A38A 14A0 DDE5
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
2004-01-12 4:43 ` Eugene Teo
@ 2004-01-12 11:23 ` Domen Puncer
2004-01-12 12:10 ` Eugene Teo
` (15 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: Domen Puncer @ 2004-01-12 11:23 UTC (permalink / raw)
To: kernel-janitors
On Monday 12 of January 2004 04:36, Randy.Dunlap wrote:
> If you haven't already noticed it, the kernel janitors web page
> has moved to http://janitor.kernelnewbies.org .
>
> That web page tells you about KJ CVS, #irc, email, etc.
# host irc.openprojects.net
Host irc.openprojects.net not found: 3(NXDOMAIN)
In TODO and README there's still the old ml address:
kernel-janitor-discuss@lists.sourceforge.net
README:
Linux 2.5 kernel bugs are tracked at <http://bugzilla.kernel.org/>
2.5/2.6 might be better?
TODO:
http://www.lib.uaa.alaska.edu/linux-kernel/archive/2001-Week-11/0150.html
gives 404
May i suggest adding this to TODO:
- replacing __FUNCTION__ with __func__ .
- pr_debug() from kernel.h could replace a lot of DPRINTK and similar macros.
- same for pr_info()
- min/max macros from kernel.h are safe, a lot of handcrafted MIN/MAX are not.
Domen
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
2004-01-12 4:43 ` Eugene Teo
2004-01-12 11:23 ` Domen Puncer
@ 2004-01-12 12:10 ` Eugene Teo
2004-01-12 12:39 ` Christoph Hellwig
` (14 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: Eugene Teo @ 2004-01-12 12:10 UTC (permalink / raw)
To: kernel-janitors
<quote sender="Domen Puncer">
> On Monday 12 of January 2004 04:36, Randy.Dunlap wrote:
> > If you haven't already noticed it, the kernel janitors web page
> > has moved to http://janitor.kernelnewbies.org .
> >
> > That web page tells you about KJ CVS, #irc, email, etc.
>
> # host irc.openprojects.net
> Host irc.openprojects.net not found: 3(NXDOMAIN)
irc.kernelnewbies.org
> In TODO and README there's still the old ml address:
> kernel-janitor-discuss@lists.sourceforge.net
>
> README:
> Linux 2.5 kernel bugs are tracked at <http://bugzilla.kernel.org/>
> 2.5/2.6 might be better?
>
> TODO:
> http://www.lib.uaa.alaska.edu/linux-kernel/archive/2001-Week-11/0150.html
> gives 404
>
> May i suggest adding this to TODO:
> - replacing __FUNCTION__ with __func__ .
> - pr_debug() from kernel.h could replace a lot of DPRINTK and similar macros.
> - same for pr_info()
> - min/max macros from kernel.h are safe, a lot of handcrafted MIN/MAX are not.
>
>
> Domen
>
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors
>
--
Eugene TEO <eugeneteo@eugeneteo.net> <http://www.anomalistic.org/>
1024D/14A0DDE5 print D851 4574 E357 469C D308 A01E 7321 A38A 14A0 DDE5
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
` (2 preceding siblings ...)
2004-01-12 12:10 ` Eugene Teo
@ 2004-01-12 12:39 ` Christoph Hellwig
2004-01-12 13:18 ` Domen Puncer
` (13 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: Christoph Hellwig @ 2004-01-12 12:39 UTC (permalink / raw)
To: kernel-janitors
On Mon, Jan 12, 2004 at 12:23:39PM +0100, Domen Puncer wrote:
> - replacing __FUNCTION__ with __func__ .
No. We had this issue a few times already. __func__ is not supported
on older gcc releases while __FUNCTION__ works fine on all.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
` (3 preceding siblings ...)
2004-01-12 12:39 ` Christoph Hellwig
@ 2004-01-12 13:18 ` Domen Puncer
2004-01-12 17:52 ` Randy.Dunlap
` (12 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: Domen Puncer @ 2004-01-12 13:18 UTC (permalink / raw)
To: kernel-janitors
On Monday 12 of January 2004 13:39, Christoph Hellwig wrote:
> On Mon, Jan 12, 2004 at 12:23:39PM +0100, Domen Puncer wrote:
> > - replacing __FUNCTION__ with __func__ .
>
> No. We had this issue a few times already. __func__ is not supported
> on older gcc releases while __FUNCTION__ works fine on all.
Ok... but at least we can remove string concatenation with __FUNCTION__ (get
rid of warnings, and get ready for __func__):
-printk(KERN_INFO "blabla " __FUNCTION__ "\n");
+printk(KERN_INFO "blabla %s\n", __FUNCTION__);
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
` (4 preceding siblings ...)
2004-01-12 13:18 ` Domen Puncer
@ 2004-01-12 17:52 ` Randy.Dunlap
2004-01-12 18:01 ` Dave Jones
` (11 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: Randy.Dunlap @ 2004-01-12 17:52 UTC (permalink / raw)
To: kernel-janitors
On Mon, 12 Jan 2004 12:23:39 +0100 Domen Puncer <domen@coderock.org> wrote:
| On Monday 12 of January 2004 04:36, Randy.Dunlap wrote:
| > If you haven't already noticed it, the kernel janitors web page
| > has moved to http://janitor.kernelnewbies.org .
| >
| > That web page tells you about KJ CVS, #irc, email, etc.
|
| # host irc.openprojects.net
| Host irc.openprojects.net not found: 3(NXDOMAIN)
|
| In TODO and README there's still the old ml address:
| kernel-janitor-discuss@lists.sourceforge.net
|
| README:
| Linux 2.5 kernel bugs are tracked at <http://bugzilla.kernel.org/>
| 2.5/2.6 might be better?
davej fixed these (above).
| TODO:
| http://www.lib.uaa.alaska.edu/linux-kernel/archive/2001-Week-11/0150.html
| gives 404
Now says Dead URL in the TODO file. alaska.edu seems to have purged
their 2001 archives (still have 2002 and later).
If we knew what that contained, we could point to a different archive
for it.
| May i suggest adding this to TODO:
| - replacing __FUNCTION__ with __func__ .
| - pr_debug() from kernel.h could replace a lot of DPRINTK and similar macros.
| - same for pr_info()
| - min/max macros from kernel.h are safe, a lot of handcrafted MIN/MAX are not.
All added, with changes from later emails from Christoph and Domen.
--
~Randy
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
` (5 preceding siblings ...)
2004-01-12 17:52 ` Randy.Dunlap
@ 2004-01-12 18:01 ` Dave Jones
2004-01-13 11:12 ` Domen Puncer
` (10 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: Dave Jones @ 2004-01-12 18:01 UTC (permalink / raw)
To: kernel-janitors
On Mon, Jan 12, 2004 at 09:52:31AM -0800, Randy.Dunlap wrote:
> | May i suggest adding this to TODO:
> | - replacing __FUNCTION__ with __func__ .
> | - pr_debug() from kernel.h could replace a lot of DPRINTK and similar macros.
> | - same for pr_info()
> | - min/max macros from kernel.h are safe, a lot of handcrafted MIN/MAX are not.
>
> All added, with changes from later emails from Christoph and Domen.
Thanks for taking care of this, I did the quick-fix stuff earlier,
but didn't get chance to pick over the meaty parts 8-)
Dave
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
` (6 preceding siblings ...)
2004-01-12 18:01 ` Dave Jones
@ 2004-01-13 11:12 ` Domen Puncer
2004-01-13 13:38 ` Dave Jones
` (9 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: Domen Puncer @ 2004-01-13 11:12 UTC (permalink / raw)
To: kernel-janitors
On Monday 12 of January 2004 18:52, Randy.Dunlap wrote:
> On Mon, 12 Jan 2004 12:23:39 +0100 Domen Puncer <domen@coderock.org> wrote:
> | On Monday 12 of January 2004 04:36, Randy.Dunlap wrote:
> | > If you haven't already noticed it, the kernel janitors web page
> | > has moved to http://janitor.kernelnewbies.org .
> | >
> | > That web page tells you about KJ CVS, #irc, email, etc.
> |
> | # host irc.openprojects.net
> | Host irc.openprojects.net not found: 3(NXDOMAIN)
> |
> | In TODO and README there's still the old ml address:
> | kernel-janitor-discuss@lists.sourceforge.net
Ehm... kernel-janitors@lists.osdl.org and not kernel-janitors@osdl.org, it's
wrong on main page, README and TODO.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
` (7 preceding siblings ...)
2004-01-13 11:12 ` Domen Puncer
@ 2004-01-13 13:38 ` Dave Jones
2004-01-13 23:39 ` maximilian attems
` (8 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: Dave Jones @ 2004-01-13 13:38 UTC (permalink / raw)
To: kernel-janitors
On Tue, Jan 13, 2004 at 12:12:59PM +0100, Domen Puncer wrote:
> > | In TODO and README there's still the old ml address:
> > | kernel-janitor-discuss@lists.sourceforge.net
>
> Ehm... kernel-janitors@lists.osdl.org and not kernel-janitors@osdl.org, it's
> wrong on main page, README and TODO.
whoops, fixed.
Thanks,
Dave
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
` (8 preceding siblings ...)
2004-01-13 13:38 ` Dave Jones
@ 2004-01-13 23:39 ` maximilian attems
2004-01-13 23:58 ` Randy.Dunlap
` (7 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: maximilian attems @ 2004-01-13 23:39 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1.1: Type: text/plain, Size: 344 bytes --]
On Sun, 11 Jan 2004, Randy.Dunlap wrote:
>
> If you haven't already noticed it, the kernel janitors web page
> has moved to http://janitor.kernelnewbies.org .
cool !!!
> That web page tells you about KJ CVS, #irc, email, etc.
could you add a link to the kj patchset?
not bad for broader testing, isn't it ;)
regards
maks
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 163 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
` (9 preceding siblings ...)
2004-01-13 23:39 ` maximilian attems
@ 2004-01-13 23:58 ` Randy.Dunlap
2004-01-19 20:57 ` maximilian attems
` (6 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: Randy.Dunlap @ 2004-01-13 23:58 UTC (permalink / raw)
To: kernel-janitors
On Wed, 14 Jan 2004 00:39:41 +0100 maximilian attems <janitor@sternwelten.at> wrote:
| On Sun, 11 Jan 2004, Randy.Dunlap wrote:
|
| >
| > If you haven't already noticed it, the kernel janitors web page
| > has moved to http://janitor.kernelnewbies.org .
|
| cool !!!
|
| > That web page tells you about KJ CVS, #irc, email, etc.
|
| could you add a link to the kj patchset?
| not bad for broader testing, isn't it ;)
duh. done, thanks.
--
~Randy
MOTD: Always include version info.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
` (10 preceding siblings ...)
2004-01-13 23:58 ` Randy.Dunlap
@ 2004-01-19 20:57 ` maximilian attems
2004-01-19 23:08 ` Randy.Dunlap
` (5 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: maximilian attems @ 2004-01-19 20:57 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1.1: Type: text/plain, Size: 4735 bytes --]
hey randy,
just run the new page through the validator:
http://validator.w3.org/check?uri=http%3A%2F%2Fjanitor.kernelnewbies.org%2F
uuups
the html is far from being valid.
belows 2 patches make the webpage valid,
* adds document declaration 4.01 strict
* removes unused body css class
* removes center tags
* adds alt tag for pinguin
* adds 2 div containers for centred tables
=> replacement of invalid <table align="middle">
* adds extern <tr> to <th> tags
* extra minor stuff
the html patch tries to be minimal
it leaves table even if they shouldn't be used for layout.
and doesn't switch to newer xhtml.
please do not forget to apply the css patch
without it the text of the homepage would be invisible
tested on mozilla-firebird 0.7, mozilla 1.5, lynx 2.8.4rel.1
and netscape 4.77 (it didn't crash ;)
hope you like it?
a++
maks
--- kernel-janitor/index.html 2004-01-14 00:59:48.000000000 +0100
+++ kernel-janitor-maks/index.html 2004-01-19 21:49:42.000000000 +0100
@@ -1,3 +1,4 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
<html>
<head>
<title>Linux Kernel Janitor Project home page.</title>
@@ -8,22 +9,23 @@
<meta name="KeyWords" content="Linux, Kernel, Janitor, cleanup, audit, bugfixing">
</head>
-<body class="background">
+<body>
+ <div id="head_center">
-<center>
-<table width="50%" class="box">
+<table class="box">
<tr>
-<td valign="top"><img SRC="pengsmall.gif"></td>
-<td valign="top">
-<center>Welcome to The Linux Kernel Janitor Project home page.</center>
+<td valign="top"><img src="pengsmall.gif" alt="Linux Pinguin Picture "></td>
+<td valign="top" align="center">
+<p>Welcome to The Linux Kernel Janitor Project home page.</p>
</td></tr></table>
-<p>
+ </div>
+ <div id="content_center">
-<table width="90%" class="box">
+<table class="box">
<tr><td class="dark">
<table class="box" width="100%">
- <th class="th"><b>Local info:</b></th>
+ <tr><th class="th"><b>Local info:</b></th></tr>
<tr><td>
<a href="TODO">The current TODO list</a><br>
<a href="README">The project README file</a>.<br>
@@ -36,7 +38,7 @@
<p><p>
<table class="box">
- <th class="th"><b>Offsite Links:</b></th>
+ <tr><th class="th"><b>Offsite Links:</b></th></tr>
<tr><td>
<a href="http://developer.osdl.org/rddunlap/kj-patches/">kernel-janitor patchsets.</a><br>
<a href="http://bazar.conectiva.com.br/~acme/TODO">Acme's original Janitor TODO list.</a><br>
@@ -53,7 +55,7 @@
<td class="dark">
<table class="box">
- <th class="th"><b>CVS Info:</b></th>
+ <tr><th class="th"><b>CVS Info:</b></th></tr>
<tr><td>
You can also check out the current TODO from anonymous CVS using these commands:<br>
<code>cvs -d:pserver:cvs@nl.linux.org/home/CVS login</code><br>
@@ -64,25 +66,22 @@
<p><p>
- <table class="box" width=100%>
- <th class="th"><b>IRC:</b></th>
+ <table class="box" width="100%">
+ <tr><th class="th"><b>IRC:</b></th></tr>
<tr><td>
- <b>IRC</b>: irc.kernelnewbies.org #kerneljanitor</td>
+ <b>IRC</b>: irc.kernelnewbies.org #kerneljanitor
</td></tr></table>
<p><p>
- <table class="box" width=100%>
- <th class="th"><b>EMAIL:</b></th>
+ <table class="box" width="100%">
+ <tr><th class="th"><b>EMAIL:</b></th></tr>
<tr><td>
For further information, email kernel-janitors at lists.osdl.org<br>
- Mailing list subscription information is at <A href="http://lists.osdl.org/mailman/listinfo/kernel-janitors">OSDL</a></p>
+ Mailing list subscription information is at <A href="http://lists.osdl.org/mailman/listinfo/kernel-janitors">OSDL</a>
</td></tr></table>
</table>
-
-</center>
-
+</div>
</body>
</html>
-
--- kernel-janitor/style.css 2004-01-10 01:58:55.000000000 +0100
+++ kernel-janitor-maks/style.css 2004-01-19 21:08:22.000000000 +0100
@@ -3,7 +3,6 @@
font-family: verdana, arial, helvetica, sans-serif;
font-size: 12pt;
color: #000000;
- text-align: justify;
margin: 5px;
}
@@ -47,6 +46,7 @@
border-color: #000000;
border-spacing: 0px;
background-color: #ffffff;
+ text-align: center;
}
th {
@@ -57,8 +57,10 @@
}
td {
+ color: #000000;
padding: 3px;
vertical-align: top;
+ text-align: justify;
}
th.list {
@@ -100,5 +102,15 @@
list-style: circle outside url(/images/bullet.png);
}
+/* workaround table centering */
+#head_center {
+ margin: 1em auto;
+ width: 500px;
+}
+
+#content_center {
+ margin: 1em auto;
+ width: 900px;
+}
/* vim:ts=8:noexpandtab:nosmartindent:autoindent:hlsearch:
*/
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 163 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
` (11 preceding siblings ...)
2004-01-19 20:57 ` maximilian attems
@ 2004-01-19 23:08 ` Randy.Dunlap
2004-01-21 16:43 ` maximilian attems
` (4 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: Randy.Dunlap @ 2004-01-19 23:08 UTC (permalink / raw)
To: kernel-janitors
On Mon, 19 Jan 2004 21:57:49 +0100 maximilian attems <janitor@sternwelten.at> wrote:
| hey randy,
|
| just run the new page through the validator:
| http://validator.w3.org/check?uri=http%3A%2F%2Fjanitor.kernelnewbies.org%2F
| uuups
| the html is far from being valid.
|
| belows 2 patches make the webpage valid,
| * adds document declaration 4.01 strict
| * removes unused body css class
| * removes center tags
| * adds alt tag for pinguin
| * adds 2 div containers for centred tables
| => replacement of invalid <table align="middle">
| * adds extern <tr> to <th> tags
| * extra minor stuff
|
| the html patch tries to be minimal
| it leaves table even if they shouldn't be used for layout.
| and doesn't switch to newer xhtml.
|
| please do not forget to apply the css patch
| without it the text of the homepage would be invisible
|
| tested on mozilla-firebird 0.7, mozilla 1.5, lynx 2.8.4rel.1
| and netscape 4.77 (it didn't crash ;)
| hope you like it?
Applied, and thanks.
--
~Randy
Everything is relative.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
` (12 preceding siblings ...)
2004-01-19 23:08 ` Randy.Dunlap
@ 2004-01-21 16:43 ` maximilian attems
2004-01-21 16:52 ` Dave Jones
` (3 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: maximilian attems @ 2004-01-21 16:43 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1.1: Type: text/plain, Size: 4804 bytes --]
On Mon, 19 Jan 2004, Randy.Dunlap wrote:
> Applied, and thanks.
thank you!
some time latter the frontside should
be changed in xhtml using css positioning.
same story for driver-dosdonts/index.html
belows patch make this doc valid html,
tell me if you prefer extern css,
but i think here it's not necessary,
because of minimal use.
* adds document declaration 4.01 strict
* adds header style info
* removes all font tags
* removes all superfluous align="left"
* changes align="center" in css
* changes < > in < >
tested on mozilla 1.5 and lynx, no critical html stuff in there.
a++ maks
--- kernel-janitor/drivers-dosdonts/index.html 2004-01-21 15:51:56.000000000 +0100
+++ kernel-janitor-maks/drivers-dosdonts/index.html 2004-01-21 17:35:00.000000000 +0100
@@ -1,56 +1,61 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/ht=ml4/strict.dtd">
<html>
<head>
<meta http-equiv="Content-Language" content="en-us">
<meta http-equiv="Content-Type" content="text/html; charset=windows-1252">
<title>Linux Kernel and Device Drivers DOSDONTS</title>
+<style type="text/css">
+p { font-size: 0.8em; }
+h1 { font-family: Bookman Old Style; color: #800000; font-size: 1.5em; text-align: center; font-weight: normal; }
+p#img { text-align: center; }
+</style>
</head>
<body>
-<p align="center"><font size="5" color="#800000" face="Bookman Old Style">Linux
-Kernel and Device Drivers :: DOs and DON'Ts "DOSDONTS"</font></p>
-<p align="center">
-<img border="0" src="extreme_lg.jpg" width="144" height="108"></p>
-<p align="left"><font size="2">A guide to newbies and Kernel hackers of common
+<h1>Linux
+Kernel and Device Drivers :: DOs and DON'Ts "DOSDONTS"</h1>
+<p id="img">
+<img src="extreme_lg.jpg" width="144" height="108" alt="Penguin Picture"></p>
+<p>A guide to newbies and Kernel hackers of common
things to DO and DON'T when writing Kernel and device drivers code for the Linux
Operating system based on the experiences of open-source developers and TODO
-list of the Kernel janitor Project.</font></p>
-<p align="left"><font size="2">This is an effort to document known good
+list of the Kernel janitor Project.</p>
+<p>This is an effort to document known good
practices of the Kernel development community and provide them in an easy to
understand and example-plenty format to assist Kernel hackers and newbies alike
-in their Linux development work.</font></p>
-<p align="left"><font size="2">This is an open project and contributions are
+in their Linux development work.</p>
+<p>This is an open project and contributions are
welcome. However, submissions need to stay within the intended focus of
-this effort:</font></p>
+this effort:</p>
<ul>
<li>
- <p align="left"><font size="2">Back your contributions with code or valid
- references.</font></li>
+ <p>Back your contributions with code or valid
+ references.</li>
<li>
- <p align="left"><font size="2">The goal of this document is to assist
+ <p>The goal of this document is to assist
developers in producing robust and as bug-free as possible code.
Concepts such as statistics in drivers, resource monitoring, audit tools, etc.
- don't belong here and are considered bloat.</font></li>
+ don't belong here and are considered bloat.</li>
<li>
- <p align="left"><font size="2">Follow the Linux CodingStyle and generate
- patches to be applied with a -p1 flag.</font></li>
+ <p>Follow the Linux CodingStyle and generate
+ patches to be applied with a -p1 flag.</li>
<li>
- <p align="left"><font size="2">Make sure you're not violating any licensing or
- copyrights.</font></li>
+ <p>Make sure you're not violating any licensing or
+ copyrights.</li>
</ul>
-<p align="left"> </p>
-<p align="left"><font size="2">Links to Documents:</font></p>
-<p align="left"><font size="2"><a href="../docs/driver-howto.html">DOSDONTS HTML version</font></p></a>
-<p align="left"><font size="2"><a href="../docs/driver-howto.txt">DOSDONTS Text version</font></p></a>
-<p align="left"> </p>
-<p align="left">Related projects:</p>
-<p align="left"><a href="../">Kernel-Janitor Project</a></p>
-
-<br>
-For questions or comments please contact Tariq Shureih <tariq.shureih@intel.com>
-<br><br>
-<br><br>
+<p> </p>
+<p>Links to Documents:</p>
+<p><a href="../docs/driver-howto.html">DOSDONTS HTML version</a></p>
+<p><a href="../docs/driver-howto.txt">DOSDONTS Text version</a></p>
+<p> </p>
+<p>Related projects:</p>
+<p><a href="../">Kernel-Janitor Project</a></p>
+
+<p>
+For questions or comments please contact Tariq Shureih <tariq.shureih@intel.com>
+</p>
</body>
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 163 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
` (13 preceding siblings ...)
2004-01-21 16:43 ` maximilian attems
@ 2004-01-21 16:52 ` Dave Jones
2004-01-21 16:52 ` maximilian attems
` (2 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: Dave Jones @ 2004-01-21 16:52 UTC (permalink / raw)
To: kernel-janitors
On Wed, Jan 21, 2004 at 05:43:32PM +0100, maximilian attems wrote:
> On Mon, 19 Jan 2004, Randy.Dunlap wrote:
>
> > Applied, and thanks.
>
> thank you!
> some time latter the frontside should
> be changed in xhtml using css positioning.
>
>
> same story for driver-dosdonts/index.html
> belows patch make this doc valid html,
> tell me if you prefer extern css,
> but i think here it's not necessary,
> because of minimal use.
If you've the time to hack on this, maybe we should just
get you fitted up with a cvs account.
Dave
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
` (14 preceding siblings ...)
2004-01-21 16:52 ` Dave Jones
@ 2004-01-21 16:52 ` maximilian attems
2004-01-21 17:01 ` Randy.Dunlap
2004-01-21 17:37 ` maximilian attems
17 siblings, 0 replies; 19+ messages in thread
From: maximilian attems @ 2004-01-21 16:52 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1.1: Type: text/plain, Size: 11695 bytes --]
hey randy,
the last "local" html ;)
same story for the docs/driver-howto.html
again if you prefer outside css file,
please tell .. here there is a bit more css,
in order to look like the original.
belows patch make this document valid:
* adds document declaration 4.01 strict
* split up invalid meta tag in 2
* adds header css information
* removes superfluous defs, font tags
* restore right order of nested tags
<hx><a> ..</hx></a> -> <hx><a> .. </a></hx>
* souround all non formated text with <pre> </pre>
* change "e, <, > -> ", <, >
tested on mozilla 1.5 and lynx.
hope this helps
regards maks
--- kernel-janitor/docs/driver-howto.html 2004-01-09 22:09:18.000000000 +0100
+++ kernel-janitor-maks/docs/driver-howto.html 2004-01-21 17:25:47.000000000 +0100
@@ -1,18 +1,30 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/ht=ml4/strict.dtd">
<html>
<head>
<title>Dos and Don't when writing a Linux Device Driver</title>
-<meta name="Tariq Shureih" content="Vim/6.1">
+<meta name="Author" content="Tariq Shureih">
+<meta name="Editor" content="Vim/6.1">
+<meta http-equiv="content-type" content="text/html; charset=iso-8859-15">
+<style type="text/css">
+h1 { text-align: center; }
+div.mid { text-align: center; }
+h2 { font-size: 1.1em; font-family: Courier New, Courier, monospace; }
+h3 { font-size: 1.0em; font-family: Courier New, Courier, monospace; }
+h4 { font-size: 0.8EM; font-family: Courier New, Courier, monospace; }
+li { font-size: 0.8em; font-family: Courier New, Courier, monospace; }
+</style>
</head>
-<body bgcolor="#ffffff" text="#000000">
-<strong><div align="center"><h1>HOWTO: Linux Device Driver Dos and Don'ts</strong></h1></div>
+<body>
+<h1>HOWTO: Linux Device Driver Dos and Don'ts</h1>
-<div align="center"> Linux Device Drivers DOs and DON'Ts
+<div class="mid"> Linux Device Drivers DOs and DON'Ts
A guide to writing Robust Linux Device Drivers</div>
-<dev align="center">Version 1.1</div>
+<div>Version 1.1</div>
<pre>
---------------------------------------------------------------------
-<h2>Index</h2>
+</pre>
+<h2>Index</h2><p> <p>
<ul>
<li><a href="#license">License, author and version</a>
<li><a href="#intro">Introduction</a>
@@ -40,10 +52,19 @@
+<pre>
+
+
+
+
+
+
-----------------------------------------------------------------------
-<h3><a NAME="license">License, author and version</h3></a>
+----------------------------------------------------------------------
+</pre>
+<h3><a NAME="license">License, author and version</a></h3>
+<pre>
Copyright (c) 2003 by Intel Corporation. This material may be
distributed only subject to the terms and conditions set forth
in the Open Publication License, v1.0 or later.
@@ -51,13 +72,15 @@
The latest version is presently available at:
<a href="http://www.opencontent.org/openpub.">http://www.opencontent.org/openpub.</a>
-Author: Tariq Shureih <tariq.shureih@intel.com>
+Author: Tariq Shureih <tariq.shureih@intel.com>
Version: 1.1
Date updated:$Date: 2004/01/09 21:09:18 $
-<h3><a NAME="intro">Introduction</h3></a>
+</pre>
+<h3><a NAME="intro">Introduction</a></h3>
+<pre>
This document is not a real driver HOWTO -- there are books out there on
how to write a linux kernel driver.
Writing a linux kernel driver can be as simple as writing three lines
@@ -74,8 +97,10 @@
For more information on the Kernel-Janitor project, visit http://kernel-janitor.sourceforge.net/.
-<h2><a NAME="ov">1-Overview</h2></a>
- <h3><a NAME="1.1">1.1 Why this document?</h3></a>
+</pre>
+<h2><a NAME="ov">1-Overview</a></h2>
+ <h3><a NAME="1.1">1.1 Why this document?</a></h3>
+<pre>
I wanted to collect the information I learned when I got involved in kernel development
in a single document and hopefully make it a guide to newbies and/or people looking for
@@ -84,8 +109,9 @@
This document is rather a simple guide to known methods and techniques when writing
a Linux device driver and it could be regarded as a companion to other available resources.
-
- <h3><a NAME="1.2">1.2 What's a "Hardened Device Driver"?</h3></a>
+</pre>
+ <h3><a NAME="1.2">1.2 What's a "Hardened Device Driver"?</a></h3>
+<pre>
The answer to this question depends on who you ask. To some, a hardened
device driver is a stable, reliable, instrumental and highly available device
driver. In a previous effort to specify what constitutes a hardened driver, a
@@ -109,7 +135,9 @@
To avoid confusion with previous efforts to speficy the requirements of a hardened driver,
this document will refer to the ideal driver as an "robust" driver.
- <h3><a NAME="1.3">1.3 Robust device drivers</h3></a>
+</pre>
+ <h3><a NAME="1.3">1.3 Robust device drivers</a></h3>
+<pre>
A robust driver is really just a robust, bug free and maintainable example of kernel level code.
As Linux evolves, the specifics of what makes up a robust device driver will change, but the
@@ -150,8 +178,9 @@
robust device drivers.
-
- <h2><a NAME="2.0">2.0 Where do I start?</h2></a>
+</pre>
+ <h2><a NAME="2.0">2.0 Where do I start?</a></h2>
+<pre>
If you're new to writing Linux device drivers, you're probably better off getting a copy of O'Reilly's book
"Linux Device Drivers", reading the "linux-kernel-source/Documentation/driver-model", and looking through
@@ -169,13 +198,15 @@
Further, I hope this document will help you in avoiding common DON'Ts and shed light on advocated DOs that
will help your driver and code function at the highest levels of performance.
-
- <h2><a NAME="3.0">3.0 OK, I'm ready...</h2></a>
+</pre>
+ <h2><a NAME="3.0">3.0 OK, I'm ready...</a></h2>
+<pre>
Let's start examining the aspects of a robust device driver code and the various techniques to achieve
high efficiency and stability.
-
- <h4><a NAME="3.1">3.1 Efficient error handling, reporting and recovery:</h4></a>
+</pre>
+ <h4><a NAME="3.1">3.1 Efficient error handling, reporting and recovery:</a></h4>
+<pre>
You can follow some simple and proven ways to handle errors and faults within your code:
@@ -348,8 +379,9 @@
What this document advocates against is the "lazy" panics where the developer did not
have an understanding of the full picture and opted to panic() out for simplicity.
-
- <h4><a NAME="3.2">3.2 Up-to-date with kernel APIs/Interfaces:</h4></a>
+</pre>
+ <h4><a NAME="3.2">3.2 Up-to-date with kernel APIs/Interfaces:</a></h4>
+<pre>
This document was written during the development of the 2.6 Linux kernel.
During the development and various releases of linux-2.5.x, many concepts, interfaces
@@ -364,8 +396,9 @@
experience while contributing to linux kernel and gathered input from experienced
developers in the open source community.
-
- <h4><a NAME="3.2.1">3.2.1 Module interface changes</h4></a>
+</pre>
+ <h4><a NAME="3.2.1">3.2.1 Module interface changes</a></h4>
+<pre>
<Initialization and cleanup>
@@ -411,7 +444,7 @@
}
- <u>You no longer need to adjust your own module reference count</u>
+ <b>You no longer need to adjust your own module reference count</b>
-Reference counting from other modules:
@@ -456,8 +489,9 @@
See 3.2.2 Sysfs and new driver model below.
-
- <h4><a NAME="3.2.2">3.2.2 Sysfs and new driver model</h4></a>
+</pre>
+ <h4><a NAME="3.2.2">3.2.2 Sysfs and new driver model</a></h4>
+<pre>
Reference: linux-kernel-source/Documentation/driver-model/
Reference: linux-kernel-source/Documentation/filesystems/sysfs.txt
@@ -762,7 +796,9 @@
is not driver-wide and is only available (in this example) if the device itself provided
functionality specific to it and is not implemented in the generic driver.
- <h4><a NAME="3.2.3">3.2.3 Cli() and Sti()</h4></a>
+</pre>
+ <h4><a NAME="3.2.3">3.2.3 Cli() and Sti()</a></h4>
+<pre>
Starting linux-2.5.x and targeted for linux-2.6.x, the following functions (macros)
are absolete and have been deprecated:
@@ -800,8 +836,9 @@
The spinlock functions (actually macros) are defined in:
linux/include/linux/spinlock.h
-
- <h4><a NAME="3.2.4">Misc pointers to new API</h4></a>
+</pre>
+ <h4><a NAME="3.2.4">Misc pointers to new API</a></h4>
+<pre>
-proc_register is dead, use create_proc_entry() instead.
@@ -829,14 +866,16 @@
-sleep_on() function will go away in 2.5/2.6 kernels.
-
- <h3><a NAME="3.3">3.3 Managing resources:</h3></a>
+</pre>
+ <h3><a NAME="3.3">3.3 Managing resources:</a></h3>
+<pre>
In this section we will look at the various resource allocation
methods, variable initialization, balancing function calls and
proper string function for drivers.
-
- <h4><a NAME="3.3.1">3.3.1 String functions</h4></a>
+</pre>
+ <h4><a NAME="3.3.1">3.3.1 String functions</a></h4>
+<pre>
-strtok() is not thread and SMP safe and strsep() should be used
instead:
@@ -854,8 +893,9 @@
Same goes with the store() method. It should return the number of
bytes used from the buffer using strnlen().
-
- <h4><a NAME="3.3.2">3.3.2 Variable declaration and initialization.</h4></a>
+</pre>
+ <h4><a NAME="3.3.2">3.3.2 Variable declaration and initialization.</a></h4>
+<pre>
-For optimal assembly code output, declaring
[const] char foo[] = "blah";
@@ -875,8 +915,9 @@
have to search for all instances of "sizeof(type)" and update
them.
-
- <h4><a NAME="3.3.3">3.3.3 Balancing functions:</h4></a>
+</pre>
+ <h4><a NAME="3.3.3">3.3.3 Balancing functions:</a></h4>
+<pre>
It is important to make sure all your function calls for resource
allocation/release are balanced and matched on the other end and
@@ -893,10 +934,11 @@
partner to void dead-locks.
-
- <h3><a NAME="3.4">3.4 I/O operations:</h3></a>
+</pre>
+ <h3><a NAME="3.4">3.4 I/O operations:</a></h3>
<h4><a NAME="3.4.1">3.4.1 All I/O space access should use the C I/O functions instead of assembly
- code.</h4></a>
+ code.</a></h4>
+<pre>
These functions are:
Byte I/O read/writes:
@@ -923,9 +965,10 @@
__asm__( "mov $0, %al\n\t" "outb %al, $0x70");
should be:
outb(0x00, 0x70);
-
+</pre>
<h4><a NAME="3.4.2">3.4.2 All memory mapped I.O access should use read()/write()
- functions instead of de-referencing a pointer.</h4></a>
+ functions instead of de-referencing a pointer.</a></h4>
+<pre>
These functions are:
@@ -946,10 +989,11 @@
Note: you have to use the -O2 optimization flag while compiling for
these functions (macros really) to expand.
+</pre>
+ <h4><a NAME="3.5">3.5 Obvious DONTZ</a></h4>
+<pre>
- <h4><a NAME="3.5">3.5 Obvious DONTZ</h4></a>
-
- -Device drivers should never add a "e;syscall"e;.
+ -Device drivers should never add a "syscall".
system calls are decided by the linux maintainers and involve
assembly code and mess with software interrup (int 0x80); something
drivers should never do.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 163 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
` (15 preceding siblings ...)
2004-01-21 16:52 ` maximilian attems
@ 2004-01-21 17:01 ` Randy.Dunlap
2004-01-21 17:37 ` maximilian attems
17 siblings, 0 replies; 19+ messages in thread
From: Randy.Dunlap @ 2004-01-21 17:01 UTC (permalink / raw)
To: kernel-janitors
On Wed, 21 Jan 2004 16:52:05 +0000 Dave Jones <davej@redhat.com> wrote:
| On Wed, Jan 21, 2004 at 05:43:32PM +0100, maximilian attems wrote:
| > On Mon, 19 Jan 2004, Randy.Dunlap wrote:
| >
| > > Applied, and thanks.
| >
| > thank you!
| > some time latter the frontside should
| > be changed in xhtml using css positioning.
| >
| >
| > same story for driver-dosdonts/index.html
| > belows patch make this doc valid html,
| > tell me if you prefer extern css,
| > but i think here it's not necessary,
| > because of minimal use.
|
| If you've the time to hack on this, maybe we should just
| get you fitted up with a cvs account.
I agree. if you want it, max .....
--
~Randy
kernel-janitors project: http://janitor.kernelnewbies.org/
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Kernel-janitors] [announce] new KJ web hosting
2004-01-12 3:36 [Kernel-janitors] [announce] new KJ web hosting Randy.Dunlap
` (16 preceding siblings ...)
2004-01-21 17:01 ` Randy.Dunlap
@ 2004-01-21 17:37 ` maximilian attems
17 siblings, 0 replies; 19+ messages in thread
From: maximilian attems @ 2004-01-21 17:37 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1.1: Type: text/plain, Size: 458 bytes --]
On Wed, 21 Jan 2004, Randy.Dunlap wrote:
> On Wed, 21 Jan 2004 16:52:05 +0000 Dave Jones <davej@redhat.com> wrote:
>
> | If you've the time to hack on this, maybe we should just
> | get you fitted up with a cvs account.
>
> I agree. if you want it, max .....
thx a lot for your 2 mails!!
would be wounderfull =:-)
i will do my best.
regards
max
ps if you need my gpg key:
gpg --keyserver wwwkeys.nl.pgp.net --recv-keys 0x3363A17D
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 163 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 19+ messages in thread