* Fix up 4KB stack allocation in DVB USB driver.
@ 2004-01-21 19:38 Dave Jones
0 siblings, 0 replies; only message in thread
From: Dave Jones @ 2004-01-21 19:38 UTC (permalink / raw)
To: Linux Kernel; +Cc: linux-dvb, greg
Allocating 4KB on the stack can't be healthy.
Dave
diff -Nru a/drivers/media/dvb/ttusb-dec/ttusb_dec.c b/drivers/media/dvb/ttusb-dec/ttusb_dec.c
--- a/drivers/media/dvb/ttusb-dec/ttusb_dec.c Wed Jan 21 19:10:44 2004
+++ b/drivers/media/dvb/ttusb-dec/ttusb_dec.c Wed Jan 21 19:10:44 2004
@@ -1145,7 +1145,7 @@
0x00, 0x00, 0x00, 0x00,
0x61, 0x00 };
u8 b1[] = { 0x61 };
- u8 b[ARM_PACKET_SIZE];
+ u8 *b;
char idstring[21];
u8 *firmware = NULL;
size_t firmware_size = 0;
@@ -1202,6 +1202,10 @@
trans_count = 0;
j = 0;
+ b = kmalloc(ARM_PACKET_SIZE, GFP_KERNEL);
+ if (b == NULL)
+ return -ENOMEM;
+
for (i = 0; i < firmware_size; i += COMMAND_PACKET_SIZE) {
size = firmware_size - i;
if (size > COMMAND_PACKET_SIZE)
@@ -1228,6 +1232,8 @@
}
result = ttusb_dec_send_command(dec, 0x43, sizeof(b1), b1, NULL, NULL);
+
+ kfree(b);
return result;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-01-21 19:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-21 19:38 Fix up 4KB stack allocation in DVB USB driver Dave Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.