[Kernel-janitors] [PATCH] fix logic bugs in ps2esdi.c

[Kernel-janitors] [PATCH] fix logic bugs in ps2esdi.c

[Timmy Yee]

Hi,

This patch adds missing ampersands.

--- linux-2.6.2-rc1/drivers/block/ps2esdi.c	2003-12-03 17:03:19.000000000 -0800
+++ linux-2.6.2-rc1-mpi/drivers/block/ps2esdi.c	2004-01-24 01:53:01.000000000 -0800
@@ -743,7 +743,7 @@
 	drive_num = int_ret_code >> 5;
 	switch (int_ret_code & 0xf) {
 	case INT_CMD_COMPLETE:
-		for (i = ESDI_TIMEOUT; i & !(inb(ESDI_STATUS) & STATUS_STAT_AVAIL); i--);
+		for (i = ESDI_TIMEOUT; i && !(inb(ESDI_STATUS) & STATUS_STAT_AVAIL); i--);
 		if (!(inb(ESDI_STATUS) & STATUS_STAT_AVAIL)) {
 			printk("%s: timeout reading status word\n", DEVICE_NAME);
 			outb((int_ret_code & 0xe0) | ATT_EOI, ESDI_ATTN);
@@ -879,7 +879,7 @@
 		break;
 
 	case INT_CMD_COMPLETE:
-		for (i = ESDI_TIMEOUT; i & !(inb(ESDI_STATUS) & STATUS_STAT_AVAIL); i--);
+		for (i = ESDI_TIMEOUT; i && !(inb(ESDI_STATUS) & STATUS_STAT_AVAIL); i--);
 		if (!(inb(ESDI_STATUS) & STATUS_STAT_AVAIL)) {
 			printk("%s: timeout reading status word\n", DEVICE_NAME);
 			outb((int_ret_code & 0xe0) | ATT_EOI, ESDI_ATTN);
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH] fix logic bugs in ps2esdi.c

[Timmy Yee]

Hi Walter,

On Mon, Jan 26, 2004 at 03:16:24PM +0100, Walter Harms wrote:
> 
> hi Timmy,
> nice work,
> perhaps you can do a bit clean up ? even the autor seem to have lost track
> in its code.
> 
> walter
> 

Actually, I was planning to clean up the ps2esdi driver's module code and
port it to the new MCA API when I find some time to do so.

Later,
Timmy
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors