All of lore.kernel.org
 help / color / mirror / Atom feed
* [2.4 patch] fix two IDE warnings
@ 2004-01-26  3:19 Adrian Bunk
  0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2004-01-26  3:19 UTC (permalink / raw)
  To: andre, Marcelo Tosatti; +Cc: linux-kernel

I got the following warnings in 2.4.25-pre7:

<--  snip  -->

...
gcc-2.95 -D__KERNEL__ 
-I/home/bunk/linux/kernel-2.4/linux-2.4.25-pre7-full/include -Wall 
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common 
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=k6  -I../ 
-nostdinc -iwithprefix include -DKBUILD_BASENAME=siimage  -c -o 
siimage.o siimage.c
siimage.c: In function `pdev_is_sata':
siimage.c:65: warning: control reaches end of non-void function
...
gcc-2.95 -D__KERNEL__ 
-I/home/bunk/linux/kernel-2.4/linux-2.4.25-pre7-full/include -Wall 
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common 
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=k6  -I../ 
-nostdinc -iwithprefix include -DKBUILD_BASENAME=generic  -c -o 
generic.o generic.c
generic.h:151: warning: `unknown_chipset' defined but not used
...

<--  snip  -->

The patch below (completely stolen from 2.6) fixes these two warnings.

Please apply
Adrian


--- linux-2.4.25-pre7-full/drivers/ide/pci/siimage.c.old	2004-01-26 04:02:58.000000000 +0100
+++ linux-2.4.25-pre7-full/drivers/ide/pci/siimage.c	2004-01-26 04:03:16.000000000 +0100
@@ -62,6 +62,7 @@
 			return 0;
 	}
 	BUG();
+	return 0;
 }
  
 /**
--- linux-2.4.25-pre7-full/drivers/ide/pci/generic.h.old	2004-01-26 04:05:31.000000000 +0100
+++ linux-2.4.25-pre7-full/drivers/ide/pci/generic.h	2004-01-26 04:05:46.000000000 +0100
@@ -148,6 +148,7 @@
 	}
 };
 
+#if 0
 static ide_pci_device_t unknown_chipset[] __devinitdata = {
 	{	/* 0 */
 		.vendor		= 0,
@@ -170,5 +171,6 @@
 	}
 
 };
+#endif
 
 #endif /* IDE_GENERIC_H */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-01-26  3:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-26  3:19 [2.4 patch] fix two IDE warnings Adrian Bunk

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.