* iptables/extensions/libipt_time.c missing include
@ 2004-01-23 2:06 laurent.ml
2004-01-23 9:52 ` Bastian Blank
0 siblings, 1 reply; 6+ messages in thread
From: laurent.ml @ 2004-01-23 2:06 UTC (permalink / raw)
To: netfilter-devel
Hi,
Tell me if I'm wrong, it seems an include is missing in
extensions/libipt_time.c from iptables cvs.
(line 302 : offsetof)
--- extensions/libipt_time.c.ancien 2004-01-23 02:59:59.000000000
+0100
+++ extensions/libipt_time.c 2004-01-23 02:54:17.000000000 +0100
@@ -3,6 +3,7 @@
#include <netdb.h>
#include <string.h>
#include <stdlib.h>
+#include <linux/stddef.h>
#include <getopt.h>
#include <iptables.h>
--
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: iptables/extensions/libipt_time.c missing include
2004-01-23 2:06 iptables/extensions/libipt_time.c missing include laurent.ml
@ 2004-01-23 9:52 ` Bastian Blank
2004-01-27 10:57 ` Harald Welte
0 siblings, 1 reply; 6+ messages in thread
From: Bastian Blank @ 2004-01-23 9:52 UTC (permalink / raw)
To: netfilter-devel
[-- Attachment #1: Type: text/plain, Size: 419 bytes --]
On Fri, Jan 23, 2004 at 03:06:45AM +0100, laurent.ml@linuxfr.org wrote:
> Tell me if I'm wrong, it seems an include is missing in
> extensions/libipt_time.c from iptables cvs.
> (line 302 : offsetof)
You should use <stddef.h> instead of <linux/stddef.h>.
Bastian
--
"... freedom ... is a worship word..."
"It is our worship word too."
-- Cloud William and Kirk, "The Omega Glory", stardate unknown
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: iptables/extensions/libipt_time.c missing include
2004-01-23 9:52 ` Bastian Blank
@ 2004-01-27 10:57 ` Harald Welte
2004-01-27 11:41 ` Bastian Blank
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Harald Welte @ 2004-01-27 10:57 UTC (permalink / raw)
To: netfilter-devel
[-- Attachment #1: Type: text/plain, Size: 829 bytes --]
On Fri, Jan 23, 2004 at 10:52:34AM +0100, Bastian Blank wrote:
> On Fri, Jan 23, 2004 at 03:06:45AM +0100, laurent.ml@linuxfr.org wrote:
> > Tell me if I'm wrong, it seems an include is missing in
> > extensions/libipt_time.c from iptables cvs.
> > (line 302 : offsetof)
>
> You should use <stddef.h> instead of <linux/stddef.h>.
At least on my debian machines /usr/include/stddef.h doesn't exist.
Thus, I'm accepting the patch.
> Bastian
--
- Harald Welte <laforge@netfilter.org> http://www.netfilter.org/
============================================================================
"Fragmentation is like classful addressing -- an interesting early
architectural error that shows how much experimentation was going
on while IP was being designed." -- Paul Vixie
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: iptables/extensions/libipt_time.c missing include
2004-01-27 10:57 ` Harald Welte
@ 2004-01-27 11:41 ` Bastian Blank
[not found] ` <Pine.LNX.4.44.0401271300460.16067-100000@filer.marasystems.com>
2004-01-27 18:13 ` Stephen Lee
2 siblings, 0 replies; 6+ messages in thread
From: Bastian Blank @ 2004-01-27 11:41 UTC (permalink / raw)
To: netfilter-devel; +Cc: Harald Welte
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
On Tue, Jan 27, 2004 at 11:57:45AM +0100, Harald Welte wrote:
> > You should use <stddef.h> instead of <linux/stddef.h>.
> At least on my debian machines /usr/include/stddef.h doesn't exist.
It don't exists there, because it is shipped with the gcc.
Bastian
--
Phasers locked on target, Captain.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: iptables/extensions/libipt_time.c missing include
[not found] ` <Pine.LNX.4.44.0401271300460.16067-100000@filer.marasystems.com>
@ 2004-01-27 13:08 ` Harald Welte
0 siblings, 0 replies; 6+ messages in thread
From: Harald Welte @ 2004-01-27 13:08 UTC (permalink / raw)
To: Henrik Nordstrom; +Cc: Netfilter Development Mailinglist
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
On Tue, Jan 27, 2004 at 01:02:17PM +0100, Henrik Nordstrom wrote:
> > At least on my debian machines /usr/include/stddef.h doesn't exist.
>
> There should be one in your gcc include directory. It is a compiler
> dependent include, not a system dependent one.
stupid me, thanks.
> Regards
> Henrik
--
- Harald Welte <laforge@netfilter.org> http://www.netfilter.org/
============================================================================
"Fragmentation is like classful addressing -- an interesting early
architectural error that shows how much experimentation was going
on while IP was being designed." -- Paul Vixie
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: iptables/extensions/libipt_time.c missing include
2004-01-27 10:57 ` Harald Welte
2004-01-27 11:41 ` Bastian Blank
[not found] ` <Pine.LNX.4.44.0401271300460.16067-100000@filer.marasystems.com>
@ 2004-01-27 18:13 ` Stephen Lee
2 siblings, 0 replies; 6+ messages in thread
From: Stephen Lee @ 2004-01-27 18:13 UTC (permalink / raw)
To: netfilter-devel; +Cc: Stephen Lee
Harald Welte <laforge@netfilter.org> wrote:
> On Fri, Jan 23, 2004 at 10:52:34AM +0100, Bastian Blank wrote:
> > On Fri, Jan 23, 2004 at 03:06:45AM +0100, laurent.ml@linuxfr.org wrote:
> > > Tell me if I'm wrong, it seems an include is missing in
> > > extensions/libipt_time.c from iptables cvs.
> > > (line 302 : offsetof)
> >
> > You should use <stddef.h> instead of <linux/stddef.h>.
>
> At least on my debian machines /usr/include/stddef.h doesn't exist.
>
> Thus, I'm accepting the patch.
On my debian machine stddef.h is in
/usr/lib/gcc-lib/i486-linux/3.3.3/include/ and gcc can find it with
<stddef.h> when compiling normally. Not sure
about when compiling a kernel.
Stephen
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-01-27 18:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-23 2:06 iptables/extensions/libipt_time.c missing include laurent.ml
2004-01-23 9:52 ` Bastian Blank
2004-01-27 10:57 ` Harald Welte
2004-01-27 11:41 ` Bastian Blank
[not found] ` <Pine.LNX.4.44.0401271300460.16067-100000@filer.marasystems.com>
2004-01-27 13:08 ` Harald Welte
2004-01-27 18:13 ` Stephen Lee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.