All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Scott <nathans@sgi.com>
To: "Christoph Hellwig" <hch@infradead.org>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Alistair John Strachan" <s0348365@sms.ed.ac.uk>,
	linux-kernel@vger.kernel.org,
	"David Martínez Moreno" <ender@debian.org>,
	"Andrew Morton" <akpm@osdl.org>,
	linux-mm@kvack.org
Subject: Re: Fix sleep_on abuse in XFS, Was: Re: 2.6.2-rc2-mm1 (Breakage?)
Date: Thu, 29 Jan 2004 17:20:52 +1100	[thread overview]
Message-ID: <20040129062052.GC2474@frodo> (raw)
In-Reply-To: <20040128150206.A28974@infradead.org>

On Wed, Jan 28, 2004 at 03:02:06PM +0000, Christoph Hellwig wrote:
> ...
>  	INIT_LIST_HEAD(&tmp);
>  	do {
>  		/* swsusp */
>  		if (current->flags & PF_FREEZE)
>  			refrigerator(PF_IOTHREAD);
>  
> -		if (pbd_active == 1) {
> -			mod_timer(&pb_daemon_timer,
> -				  jiffies + pb_params.flush_interval.val);
> -			interruptible_sleep_on(&pbd_waitq);
> -		}
> -
> -		if (pbd_active == 0) {
> -			del_timer_sync(&pb_daemon_timer);
> -		}
> +		schedule_timeout(pb_params.flush_interval.val);

After a bit more testing, looks like we'll also need a

		current->state = TASK_INTERRUPTIBLE;

line before the schedule_timeout call, else pagebufd eats
a whole lot of system time on one CPU.

I'll send an XFS update to Linus and Andrew tomorrow after
some further testing.

thanks.

-- 
Nathan

WARNING: multiple messages have this Message-ID (diff)
From: Nathan Scott <nathans@sgi.com>
To: "Christoph Hellwig" <hch@infradead.org>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Alistair John Strachan" <s0348365@sms.ed.ac.uk>,
	linux-kernel@vger.kernel.org,
	"David Martínez Moreno" <ender@debian.org>,
	"Andrew Morton" <akpm@osdl.org>,
	linux-mm@kvack.org
Subject: Re: Fix sleep_on abuse in XFS, Was: Re: 2.6.2-rc2-mm1 (Breakage?)
Date: Thu, 29 Jan 2004 17:20:52 +1100	[thread overview]
Message-ID: <20040129062052.GC2474@frodo> (raw)
In-Reply-To: <20040128150206.A28974@infradead.org>

On Wed, Jan 28, 2004 at 03:02:06PM +0000, Christoph Hellwig wrote:
> ...
>  	INIT_LIST_HEAD(&tmp);
>  	do {
>  		/* swsusp */
>  		if (current->flags & PF_FREEZE)
>  			refrigerator(PF_IOTHREAD);
>  
> -		if (pbd_active == 1) {
> -			mod_timer(&pb_daemon_timer,
> -				  jiffies + pb_params.flush_interval.val);
> -			interruptible_sleep_on(&pbd_waitq);
> -		}
> -
> -		if (pbd_active == 0) {
> -			del_timer_sync(&pb_daemon_timer);
> -		}
> +		schedule_timeout(pb_params.flush_interval.val);

After a bit more testing, looks like we'll also need a

		current->state = TASK_INTERRUPTIBLE;

line before the schedule_timeout call, else pagebufd eats
a whole lot of system time on one CPU.

I'll send an XFS update to Linus and Andrew tomorrow after
some further testing.

thanks.

-- 
Nathan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

  reply	other threads:[~2004-01-29  6:22 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-28  7:34 2.6.2-rc2-mm1 Andrew Morton
2004-01-28  7:34 ` 2.6.2-rc2-mm1 Andrew Morton
2004-01-28  7:55 ` 2.6.2-rc2-mm1 Mike Fedyk
2004-01-28  7:55   ` 2.6.2-rc2-mm1 Mike Fedyk
2004-01-28  8:18 ` ALSA noise (was: Re: 2.6.2-rc2-mm1) Joshua Kwan
2004-01-28  8:36 ` 2.6.2-rc2-mm1 Han Boetes
2004-01-30  2:51   ` 2.6.2-rc2-mm1 Adrian Bunk
2004-01-30  6:00     ` 2.6.2-rc2-mm1 Han Boetes
2004-02-04  8:22       ` 2.6: Voyager requires SMP? Adrian Bunk
2004-02-04 17:04         ` James Bottomley
2004-01-28  9:41 ` 2.6.2-rc2-mm1 Christoph Hellwig
2004-01-28  9:41   ` 2.6.2-rc2-mm1 Christoph Hellwig
2004-01-28 19:38   ` 2.6.2-rc2-mm1 David S. Miller
2004-01-28 19:38     ` 2.6.2-rc2-mm1 David S. Miller
2004-01-28 12:08 ` 2.6.2-rc2-mm1 Ramon Rey Vicente
2004-01-28 12:08 ` 2.6.2-rc2-mm1 Ralf Hildebrandt
2004-01-28 12:13 ` 2.6.2-rc2-mm1 (Breakage?) David Martínez Moreno
2004-01-28 12:13   ` David Martínez Moreno
2004-01-28 12:25   ` Alistair John Strachan
2004-01-28 12:25     ` Alistair John Strachan
2004-01-28 13:33     ` Fix sleep_on abuse in XFS, Was: " Christoph Hellwig
2004-01-28 13:33       ` Christoph Hellwig
2004-01-28 14:28       ` David Woodhouse
2004-01-28 14:28         ` David Woodhouse
2004-01-28 15:02         ` Christoph Hellwig
2004-01-28 15:02           ` Christoph Hellwig
2004-01-29  6:20           ` Nathan Scott [this message]
2004-01-29  6:20             ` Nathan Scott
2004-01-29 23:37     ` Alexander Hoogerhuis
2004-01-29 23:37       ` Alexander Hoogerhuis
2004-01-30  1:08       ` Daniel Andersen
2004-01-28 12:17 ` 2.6.2-rc2-mm1 Nikita Danilov
2004-01-28 12:17   ` 2.6.2-rc2-mm1 Nikita Danilov
2004-01-28 13:08 ` 2.6.2-rc2-mm1 Stian Jordet
2004-01-28 13:08   ` 2.6.2-rc2-mm1 Stian Jordet
2004-01-28 15:32 ` 2.6.2-rc2-mm1 Randy.Dunlap
2004-01-28 15:32   ` 2.6.2-rc2-mm1 Randy.Dunlap
2004-01-28 21:25   ` 2.6.2-rc2-mm1 Andrew Morton
2004-01-28 21:25     ` 2.6.2-rc2-mm1 Andrew Morton
2004-01-28 17:02 ` [BUG] [2.6.2-rc2-mm1] Badness in try_to_wake_up at kernel/sched.c:722 (was Re: 2.6.2-rc2-mm1) Ramon Rey Vicente
2004-01-28 19:55 ` 2.6.2-rc2-mm1 Torrey Hoffman
2004-01-28 19:55   ` 2.6.2-rc2-mm1 Torrey Hoffman
2004-01-28 20:04 ` 2.6.2-rc2-mm1 Olaf Hering
2004-01-29  0:34   ` 2.6.2-rc2-mm1 Adrian Bunk
2004-01-29 16:15 ` 2.6.2-rc2-mm1 Zephaniah E. Hull
2004-01-30 10:48 ` 2.6.2-rc2-mm1 Zephaniah E. Hull
2004-01-30 11:02   ` 2.6.2-rc2-mm1 Vojtech Pavlik
2004-01-30 11:02     ` 2.6.2-rc2-mm1 Vojtech Pavlik
2004-01-30 11:18     ` 2.6.2-rc2-mm1 Zephaniah E. Hull
2004-01-30 11:20       ` 2.6.2-rc2-mm1 Vojtech Pavlik
2004-01-30 11:20         ` 2.6.2-rc2-mm1 Vojtech Pavlik
2004-01-30 12:41         ` 2.6.2-rc2-mm1 Zephaniah E. Hull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040129062052.GC2474@frodo \
    --to=nathans@sgi.com \
    --cc=akpm@osdl.org \
    --cc=dwmw2@infradead.org \
    --cc=ender@debian.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=s0348365@sms.ed.ac.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.