From: Tim Hockin <thockin@hockin.org>
To: John Stoffel <stoffel@lucent.com>
Cc: Andrew Morton <akpm@osdl.org>,
thockin@sun.com, arjanv@redhat.com, thomas.schlichter@web.de,
thoffman@arnor.net, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: 2.6.2-rc2-mm2
Date: Fri, 30 Jan 2004 13:52:09 -0800 [thread overview]
Message-ID: <20040130215209.GA29010@hockin.org> (raw)
In-Reply-To: <16410.51656.221208.976055@gargle.gargle.HOWL>
On Fri, Jan 30, 2004 at 04:16:56PM -0500, John Stoffel wrote:
> Andrew> static long do_setgroups(int gidsetsize, gid_t __user *user_grouplist,
> Andrew> gid_t *kern_grouplist)
> Andrew> {
> Andrew> gid_t groups[NGROUPS];
>
> Call me stupid, but what if we accept the patches to increase the
> number of groups, won't that make this array be huge potentially?
> Shouldn't we instead do a kmalloc() using current->ngroups instead?
One of the things you CAN'T do anymore is an array of NGROUPS. That is why
struct group_info is there. Andrew's suggestion was a sketch, not a patch :)
WARNING: multiple messages have this Message-ID (diff)
From: Tim Hockin <thockin@hockin.org>
To: John Stoffel <stoffel@lucent.com>
Cc: Andrew Morton <akpm@osdl.org>,
thockin@sun.com, arjanv@redhat.com, thomas.schlichter@web.de,
thoffman@arnor.net, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: 2.6.2-rc2-mm2
Date: Fri, 30 Jan 2004 13:52:09 -0800 [thread overview]
Message-ID: <20040130215209.GA29010@hockin.org> (raw)
In-Reply-To: <16410.51656.221208.976055@gargle.gargle.HOWL>
On Fri, Jan 30, 2004 at 04:16:56PM -0500, John Stoffel wrote:
> Andrew> static long do_setgroups(int gidsetsize, gid_t __user *user_grouplist,
> Andrew> gid_t *kern_grouplist)
> Andrew> {
> Andrew> gid_t groups[NGROUPS];
>
> Call me stupid, but what if we accept the patches to increase the
> number of groups, won't that make this array be huge potentially?
> Shouldn't we instead do a kmalloc() using current->ngroups instead?
One of the things you CAN'T do anymore is an array of NGROUPS. That is why
struct group_info is there. Andrew's suggestion was a sketch, not a patch :)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-01-30 21:52 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-30 9:41 2.6.2-rc2-mm2 Andrew Morton
2004-01-30 9:41 ` 2.6.2-rc2-mm2 Andrew Morton
2004-01-30 10:52 ` 2.6.2-rc2-mm2 Helge Hafting
2004-01-30 10:52 ` 2.6.2-rc2-mm2 Helge Hafting
2004-01-30 11:14 ` 2.6.2-rc2-mm2 Zephaniah E. Hull
2004-01-30 16:25 ` 2.6.2-rc2-mm2 Gene Heskett
2004-01-30 16:25 ` 2.6.2-rc2-mm2 Gene Heskett
2004-01-30 17:25 ` 2.6.2-rc2-mm2 Gene Heskett
2004-01-30 17:25 ` 2.6.2-rc2-mm2 Gene Heskett
2004-01-30 18:58 ` 2.6.2-rc2-mm2 Torrey Hoffman
2004-01-30 18:58 ` 2.6.2-rc2-mm2 Torrey Hoffman
2004-01-30 19:07 ` 2.6.2-rc2-mm2 Thomas Schlichter
2004-01-30 19:23 ` 2.6.2-rc2-mm2 Arjan van de Ven
2004-01-30 19:47 ` 2.6.2-rc2-mm2 Andrew Morton
2004-01-30 19:47 ` 2.6.2-rc2-mm2 Andrew Morton
2004-01-30 19:55 ` 2.6.2-rc2-mm2 Arjan van de Ven
2004-01-30 20:17 ` 2.6.2-rc2-mm2 Tim Hockin
2004-01-30 20:17 ` 2.6.2-rc2-mm2 Tim Hockin
2004-01-30 20:33 ` 2.6.2-rc2-mm2 Andrew Morton
2004-01-30 20:33 ` 2.6.2-rc2-mm2 Andrew Morton
2004-01-30 21:12 ` 2.6.2-rc2-mm2 Tim Hockin
2004-01-30 21:12 ` 2.6.2-rc2-mm2 Tim Hockin
2004-01-30 22:00 ` 2.6.2-rc2-mm2 Andrew Morton
2004-01-30 22:00 ` 2.6.2-rc2-mm2 Andrew Morton
2004-01-30 22:31 ` 2.6.2-rc2-mm2 Tim Hockin
2004-01-30 23:08 ` 2.6.2-rc2-mm2 Andrew Morton
2004-01-30 23:08 ` 2.6.2-rc2-mm2 Andrew Morton
2004-01-30 23:21 ` 2.6.2-rc2-mm2 Tim Hockin
2004-01-30 23:21 ` 2.6.2-rc2-mm2 Tim Hockin
2004-01-30 23:31 ` 2.6.2-rc2-mm2 Andrew Morton
2004-01-30 23:31 ` 2.6.2-rc2-mm2 Andrew Morton
2004-01-30 23:43 ` 2.6.2-rc2-mm2 Tim Hockin
2004-01-30 23:43 ` 2.6.2-rc2-mm2 Tim Hockin
2004-01-30 21:16 ` 2.6.2-rc2-mm2 John Stoffel
2004-01-30 21:16 ` 2.6.2-rc2-mm2 John Stoffel
2004-01-30 21:52 ` Tim Hockin [this message]
2004-01-30 21:52 ` 2.6.2-rc2-mm2 Tim Hockin
2004-02-01 10:03 ` 2.6.2-rc2-mm2 Michael Neuffer
2004-02-06 23:17 ` of 2.6.2-rc2-mm2 and r8169 Francois Romieu
[not found] ` <20040207115054.GC5704@neuffer.info>
[not found] ` <20040207132124.A7344@electric-eye.fr.zoreil.com>
[not found] ` <20040208064859.GA29384@neuffer.info>
2004-02-09 23:57 ` [patch] [rft] " Francois Romieu
[not found] <1jDrO-4xh-13@gated-at.bofh.it>
2004-01-30 11:10 ` 2.6.2-rc2-mm2 Ronny V. Vindenes
2004-01-30 17:27 ` 2.6.2-rc2-mm2 Andrew Morton
2004-01-30 18:06 ` 2.6.2-rc2-mm2 Ronny V. Vindenes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040130215209.GA29010@hockin.org \
--to=thockin@hockin.org \
--cc=akpm@osdl.org \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stoffel@lucent.com \
--cc=thockin@sun.com \
--cc=thoffman@arnor.net \
--cc=thomas.schlichter@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.