All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Christoph Hellwig <hch@lst.de>, Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	sensors@stimpy.netroedge.com,
	Linux/PPC Development <linuxppc-dev@lists.linuxppc.org>
Subject: [PATCH 2.6] Hydra i2c
Date: Thu, 19 May 2005 06:24:37 +0000	[thread overview]
Message-ID: <20040131003512.GD10465@kroah.com> (raw)
In-Reply-To: <Pine.GSO.4.58.0401251200580.20527@waterleaf.sonytel.be>

On Sun, Jan 25, 2004 at 12:22:02PM +0100, Geert Uytterhoeven wrote:
> 
> Here's a new version, incorporating these comments, and making a few more
> changes:
>   - Use struct definition in <asm/hydra.h> instead of #defined offset
>   - Remove flushes are register writes, they are no longer needed
>   - Use pci_resource_start() instead of dev->resource[].start
>   - ioremap() the whole resource instead of the first 256 bytes
>   - Check for errors returned by ioremap() and i2c_bit_add_bus()
>   - Add resource management
>   - Call iounmap() in hydra_remove() instead of in i2c_hydra_exit()
>   - Let I2C_HYDRA depend on I2C and select I2C_ALGOBIT instead of depending on
>     I2C_ALGOBIT

Looks good, I've added this to my tree and will send it on in the next
round of i2c patches.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Christoph Hellwig <hch@lst.de>, Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	sensors@stimpy.netroedge.com,
	Linux/PPC Development <linuxppc-dev@lists.linuxppc.org>
Subject: Re: [PATCH 2.6] Hydra i2c
Date: Fri, 30 Jan 2004 16:35:12 -0800	[thread overview]
Message-ID: <20040131003512.GD10465@kroah.com> (raw)
In-Reply-To: <Pine.GSO.4.58.0401251200580.20527@waterleaf.sonytel.be>


On Sun, Jan 25, 2004 at 12:22:02PM +0100, Geert Uytterhoeven wrote:
>
> Here's a new version, incorporating these comments, and making a few more
> changes:
>   - Use struct definition in <asm/hydra.h> instead of #defined offset
>   - Remove flushes are register writes, they are no longer needed
>   - Use pci_resource_start() instead of dev->resource[].start
>   - ioremap() the whole resource instead of the first 256 bytes
>   - Check for errors returned by ioremap() and i2c_bit_add_bus()
>   - Add resource management
>   - Call iounmap() in hydra_remove() instead of in i2c_hydra_exit()
>   - Let I2C_HYDRA depend on I2C and select I2C_ALGOBIT instead of depending on
>     I2C_ALGOBIT

Looks good, I've added this to my tree and will send it on in the next
round of i2c patches.

thanks,

greg k-h

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

  reply	other threads:[~2005-05-19  6:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-18 12:28 [PATCH 2.6] Hydra i2c Geert Uytterhoeven
2005-05-19  6:24 ` Geert Uytterhoeven
2004-01-18 12:49 ` Christoph Hellwig
2005-05-19  6:24   ` Christoph Hellwig
2004-01-25 11:22   ` Geert Uytterhoeven
2005-05-19  6:24     ` Geert Uytterhoeven
2004-01-31  0:35     ` Greg KH [this message]
2005-05-19  6:24       ` Greg KH
2004-01-18 23:30 ` Benjamin Herrenschmidt
2005-05-19  6:24   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040131003512.GD10465@kroah.com \
    --to=greg@kroah.com \
    --cc=benh@kernel.crashing.org \
    --cc=geert@linux-m68k.org \
    --cc=hch@lst.de \
    --cc=linuxppc-dev@lists.linuxppc.org \
    --cc=paulus@samba.org \
    --cc=sensors@stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.