Re: [patch] udevd - cleanup and better timeout handling

[Greg KH <greg@kroah.com>]

On Mon, Feb 02, 2004 at 12:50:24PM +0100, Kay Sievers wrote:
> On Mon, Feb 02, 2004 at 12:21:39AM -0800, Greg KH wrote:
> > On Mon, Feb 02, 2004 at 03:19:22AM +0100, Kay Sievers wrote:
> > > 
> > > Same patch with a fix for the stack size setting.
> > 
> > Nice, applied.
> > 
> > I also cleaned up the way the logging code works, so that now we can see
> > what program is spitting out what messages in the syslog.
> 
> Fine, I've missed it too sometimes.
> We may include unistd.h for get_pid()?

Is it needed for you to build?  It seems to work for me :)

> > Also, udevsend can _almost_ be built with klibc.  Any reason we have to
> > use a struct sockaddr_un instead of just a struct sockaddr?  If that is
> > changed than only udevd would rely on glibc.
> 
> The sockaddr doesn't contain the 108 char long pathname of the socket file.

Ah, ok, that makes more sense.

> > I don't mind udevd using glibc, I just want the programs that get run a
> > lot of different times (udev and udevsend) to be as small as possible to
> > get the best cache results.  As udevd sticks around all the time, it's
> > not as important.  Sound sane to you?
> 
> Oh, nice. Good idea.
> I have two alternatives attached:
> 
>   01-udevsend-klibc.patch
>     not the nicest, but it works
> 
>   01-klibc-unix-domain.patch
>     clean, but touches klibc sources by inserting the missing header file

I applied this version, and then cleaned up udevsend a bit more so now
it builds a 2.5kb binary using klibc.  That's very nice.

thanks,

greg k-h


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel