* [PATCH] Sun Keyboard driver
@ 2004-02-04 11:51 Erlend Aasland
2004-02-04 12:24 ` Vojtech Pavlik
0 siblings, 1 reply; 2+ messages in thread
From: Erlend Aasland @ 2004-02-04 11:51 UTC (permalink / raw)
To: Vojtech Pavlik; +Cc: Linux Kernel Mailing List
Hi,
I noticed a small bug in the sunkbd.c driver: After the keyboard name is
set, it is mistakenly overwritten by serio->phys. Path is against 2.6.2.
Regards,
Erlend Aasland
--- drivers/input/keyboard/sunkbd.c~ 2004-02-04 13:06:44.603610000 +0100
+++ drivers/input/keyboard/sunkbd.c 2004-02-04 13:09:00.603610000 +0100
@@ -275,7 +275,7 @@
set_bit(sunkbd->keycode[i], sunkbd->dev.keybit);
clear_bit(0, sunkbd->dev.keybit);
- sprintf(sunkbd->name, "%s/input", serio->phys);
+ sprintf(sunkbd->phys, "%s/input", serio->phys);
sunkbd->dev.name = sunkbd->name;
sunkbd->dev.phys = sunkbd->phys;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Sun Keyboard driver
2004-02-04 11:51 [PATCH] Sun Keyboard driver Erlend Aasland
@ 2004-02-04 12:24 ` Vojtech Pavlik
0 siblings, 0 replies; 2+ messages in thread
From: Vojtech Pavlik @ 2004-02-04 12:24 UTC (permalink / raw)
To: Erlend Aasland; +Cc: Linux Kernel Mailing List
On Wed, Feb 04, 2004 at 12:51:28PM +0100, Erlend Aasland wrote:
> Hi,
>
> I noticed a small bug in the sunkbd.c driver: After the keyboard name is
> set, it is mistakenly overwritten by serio->phys. Path is against 2.6.2.
Thanks for noticing, it's already fixed in my tree.
>
> Regards,
> Erlend Aasland
>
> --- drivers/input/keyboard/sunkbd.c~ 2004-02-04 13:06:44.603610000 +0100
> +++ drivers/input/keyboard/sunkbd.c 2004-02-04 13:09:00.603610000 +0100
> @@ -275,7 +275,7 @@
> set_bit(sunkbd->keycode[i], sunkbd->dev.keybit);
> clear_bit(0, sunkbd->dev.keybit);
>
> - sprintf(sunkbd->name, "%s/input", serio->phys);
> + sprintf(sunkbd->phys, "%s/input", serio->phys);
>
> sunkbd->dev.name = sunkbd->name;
> sunkbd->dev.phys = sunkbd->phys;
>
--
Vojtech Pavlik
SuSE Labs, SuSE CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-02-04 12:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-04 11:51 [PATCH] Sun Keyboard driver Erlend Aasland
2004-02-04 12:24 ` Vojtech Pavlik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.