All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Ben Collins <bcollins@debian.org>
Cc: Robert Gadsdon <robert@gadsdon.giointernet.co.uk>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.6.2-mm1 aka "Geriatric Wombat"
Date: Sat, 7 Feb 2004 11:13:15 -0800	[thread overview]
Message-ID: <20040207191315.GC2581@kroah.com> (raw)
In-Reply-To: <20040207172757.GQ1042@phunnypharm.org>

On Sat, Feb 07, 2004 at 12:27:58PM -0500, Ben Collins wrote:
> On Fri, Feb 06, 2004 at 10:22:00AM -0800, Greg KH wrote:
> > On Fri, Feb 06, 2004 at 09:47:30AM -0500, Ben Collins wrote:
> > > On Thu, Feb 05, 2004 at 10:26:14AM -0800, Greg KH wrote:
> > > > On Thu, Feb 05, 2004 at 01:11:21PM +0000, Robert Gadsdon wrote:
> > > > > 2.6.2-mm1 tombstone "Badness in kobject_get....." when booting:
> > > > 
> > > > Oooh, not nice.  That means a kobject is being used before it has been
> > > > initialized.  Glad to see that check finally helps out...
> > > 
> > > Doesn't sound like a bug in ieee1394. This bus for each is done on the
> > > ieee1394_bus_type, which is registered way ahead of time. Nothing is in
> > > that device list that didn't come from device_register(). Has something
> > > new changed to where I need to prep the device more before passing it to
> > > device_register()?
> > 
> > No, not at all.  You are initializing the structure to 0 before setting
> > any fields in it, right?  But that wouldn't be the symptom we are seeing
> > here...
> 
> Yeah, it's being memset() to zero. After that I set the parent and the
> bus_id, and then call device_register().
> 
> One thing I notice is that I am not checking the return value of
> device_register(), however if that fails, the device shouldn't be in the
> device list for the bus, correct?

That is correct.  I don't see the problem either in looking at your
code...

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Ben Collins <bcollins@debian.org>
Cc: Robert Gadsdon <robert@gadsdon.giointernet.co.uk>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.6.2-mm1 aka "Geriatric Wombat"
Date: Sat, 7 Feb 2004 11:13:15 -0800	[thread overview]
Message-ID: <20040207191315.GC2581@kroah.com> (raw)
In-Reply-To: <20040207172757.GQ1042@phunnypharm.org>

On Sat, Feb 07, 2004 at 12:27:58PM -0500, Ben Collins wrote:
> On Fri, Feb 06, 2004 at 10:22:00AM -0800, Greg KH wrote:
> > On Fri, Feb 06, 2004 at 09:47:30AM -0500, Ben Collins wrote:
> > > On Thu, Feb 05, 2004 at 10:26:14AM -0800, Greg KH wrote:
> > > > On Thu, Feb 05, 2004 at 01:11:21PM +0000, Robert Gadsdon wrote:
> > > > > 2.6.2-mm1 tombstone "Badness in kobject_get....." when booting:
> > > > 
> > > > Oooh, not nice.  That means a kobject is being used before it has been
> > > > initialized.  Glad to see that check finally helps out...
> > > 
> > > Doesn't sound like a bug in ieee1394. This bus for each is done on the
> > > ieee1394_bus_type, which is registered way ahead of time. Nothing is in
> > > that device list that didn't come from device_register(). Has something
> > > new changed to where I need to prep the device more before passing it to
> > > device_register()?
> > 
> > No, not at all.  You are initializing the structure to 0 before setting
> > any fields in it, right?  But that wouldn't be the symptom we are seeing
> > here...
> 
> Yeah, it's being memset() to zero. After that I set the parent and the
> bus_id, and then call device_register().
> 
> One thing I notice is that I am not checking the return value of
> device_register(), however if that fails, the device shouldn't be in the
> device list for the bus, correct?

That is correct.  I don't see the problem either in looking at your
code...

thanks,

greg k-h
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

  reply	other threads:[~2004-02-07 19:14 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.h1qu7q8.n6mopi@ifi.uio.no>
2004-02-05 13:11 ` 2.6.2-mm1 aka "Geriatric Wombat" Robert Gadsdon
2004-02-05 13:11   ` Robert Gadsdon
2004-02-05 18:26   ` Greg KH
2004-02-05 18:26     ` Greg KH
2004-02-05 18:29     ` Ben Collins
2004-02-05 18:29       ` Ben Collins
2004-02-05 20:14       ` Andrew Morton
2004-02-05 20:14         ` Andrew Morton
2004-02-05 20:29         ` Ben Collins
2004-02-05 20:29           ` Ben Collins
2004-02-06 14:47     ` Ben Collins
2004-02-06 14:47       ` Ben Collins
2004-02-06 18:22       ` Greg KH
2004-02-06 18:22         ` Greg KH
2004-02-06 18:39         ` Ben Collins
2004-02-06 18:39           ` Ben Collins
2004-02-07 17:27         ` Ben Collins
2004-02-07 17:27           ` Ben Collins
2004-02-07 19:13           ` Greg KH [this message]
2004-02-07 19:13             ` Greg KH
2004-02-07 23:08             ` Ben Collins
2004-02-07 23:08               ` Ben Collins
2004-02-05 12:01 Luis Miguel García
2004-02-05 16:18 ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2004-02-05  9:44 Andrew Morton
2004-02-05  9:44 ` Andrew Morton
2004-02-05  9:55 ` Nikita Danilov
2004-02-05  9:55   ` Nikita Danilov
2004-02-05 10:00 ` Russell King
2004-02-05 10:00   ` Russell King
2004-02-05 10:37   ` Jeff Garzik
2004-02-05 10:37     ` Jeff Garzik
2004-02-05 10:50     ` Russell King
2004-02-05 10:50       ` Russell King
2004-02-05 11:47 ` Nick Piggin
2004-02-05 11:47   ` Nick Piggin
2004-02-05 16:11   ` Martin J. Bligh
2004-02-05 16:11     ` Martin J. Bligh
2004-02-05 16:16     ` Nick Piggin
2004-02-05 16:16       ` Nick Piggin
2004-02-05 16:20     ` Nikita Danilov
2004-02-05 16:20       ` Nikita Danilov
2004-02-05 13:57 ` Alistair John Strachan
2004-02-05 14:16   ` Lenar Lõhmus
     [not found]     ` <4022505B.1020900-w3PkqIkA8A2zQB+pC5nmwQ@public.gmane.org>
2004-02-05 21:30       ` Alistair John Strachan
2004-02-05 21:30         ` Alistair John Strachan
     [not found]         ` <200402052130.30344.s0348365-Y3tGgqFSo3OFxr2TtlUqVg@public.gmane.org>
2004-02-06  8:39           ` Lenar Lõhmus
2004-02-06  8:39             ` Lenar Lõhmus
2004-02-05 14:16 ` Matthias Urlichs
2004-02-05 17:58 ` John Cherry
2004-02-05 17:58   ` John Cherry
2004-02-05 19:23 ` Deepak Saxena
2004-02-05 19:23   ` Deepak Saxena
2004-02-05 20:05   ` Greg KH
2004-02-05 20:05     ` Greg KH
2004-02-06 18:02 ` Thomas Davis
2004-02-06 18:02   ` Thomas Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040207191315.GC2581@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=bcollins@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=robert@gadsdon.giointernet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.