* [Ocfs2-devel] Revision 30 fails to insmod
@ 2004-02-10 18:07 Villalovos, John L
2004-02-10 18:28 ` Rusty Lynch
0 siblings, 1 reply; 4+ messages in thread
From: Villalovos, John L @ 2004-02-10 18:07 UTC (permalink / raw)
To: ocfs2-devel
Just did a sync with revision 30 from the repository.
It fails to insmod.
/lib/modules/2.4.22-1.2149.nptl/unsupported/fs/ocfs2.o: unresolved
symbol OCFS_SB_GET_KDEV
It looks like the latest revision removed the definition of
OCFS_SB_GET_KDEV in src/inc/ocfs.h but is still using the macro :(
John
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Ocfs2-devel] Revision 30 fails to insmod
2004-02-10 18:07 [Ocfs2-devel] Revision 30 fails to insmod Villalovos, John L
@ 2004-02-10 18:28 ` Rusty Lynch
2004-02-10 19:10 ` Manish Singh
0 siblings, 1 reply; 4+ messages in thread
From: Rusty Lynch @ 2004-02-10 18:28 UTC (permalink / raw)
To: ocfs2-devel
On Tue, Feb 10, 2004 at 04:07:26PM -0800, Villalovos, John L wrote:
> Just did a sync with revision 30 from the repository.
>
> It fails to insmod.
>
> /lib/modules/2.4.22-1.2149.nptl/unsupported/fs/ocfs2.o: unresolved
> symbol OCFS_SB_GET_KDEV
>
> It looks like the latest revision removed the definition of
> OCFS_SB_GET_KDEV in src/inc/ocfs.h but is still using the macro :(
Here is a fix
--rusty
Index: src/inc/ocfs.h
===================================================================
--- src/inc/ocfs.h (revision 30)
+++ src/inc/ocfs.h (working copy)
@@ -1107,7 +1107,7 @@
typedef long sector_t;
#define map_bh(bh, sb, blk) \
({ \
- bh->b_dev = OCFS_SB_GET_KDEV(sb); \
+ bh->b_dev = sb->s_dev; \
bh->b_blocknr = blk; \
bh->b_state |= (1UL << BH_Mapped); \
})
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Ocfs2-devel] Revision 30 fails to insmod
@ 2004-02-10 18:36 Villalovos, John L
0 siblings, 0 replies; 4+ messages in thread
From: Villalovos, John L @ 2004-02-10 18:36 UTC (permalink / raw)
To: ocfs2-devel
Excellent. That fixed it for me.
John
> -----Original Message-----
> From: ocfs2-devel-bounces@oss.oracle.com
> [mailto:ocfs2-devel-bounces@oss.oracle.com] On Behalf Of Rusty Lynch
> Sent: Tuesday, February 10, 2004 4:26 PM
> To: manish.singh@oracle.com
> Cc: ocfs2-devel@oss.oracle.com
> Subject: Re: [Ocfs2-devel] Revision 30 fails to insmod
>
>
> On Tue, Feb 10, 2004 at 04:07:26PM -0800, Villalovos, John L wrote:
> > Just did a sync with revision 30 from the repository.
> >
> > It fails to insmod.
> >
> > /lib/modules/2.4.22-1.2149.nptl/unsupported/fs/ocfs2.o: unresolved
> > symbol OCFS_SB_GET_KDEV
> >
> > It looks like the latest revision removed the definition of
> > OCFS_SB_GET_KDEV in src/inc/ocfs.h but is still using the macro :(
>
> Here is a fix
>
> --rusty
>
> Index: src/inc/ocfs.h
> ===================================================================
> --- src/inc/ocfs.h (revision 30)
> +++ src/inc/ocfs.h (working copy)
> @@ -1107,7 +1107,7 @@
> typedef long sector_t;
> #define map_bh(bh, sb, blk) \
> ({ \
> - bh->b_dev = OCFS_SB_GET_KDEV(sb); \
> + bh->b_dev = sb->s_dev; \
> bh->b_blocknr = blk; \
> bh->b_state |= (1UL << BH_Mapped); \
> })
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel@oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Ocfs2-devel] Revision 30 fails to insmod
2004-02-10 18:28 ` Rusty Lynch
@ 2004-02-10 19:10 ` Manish Singh
0 siblings, 0 replies; 4+ messages in thread
From: Manish Singh @ 2004-02-10 19:10 UTC (permalink / raw)
To: ocfs2-devel
On Tue, Feb 10, 2004 at 04:26:21PM -0800, Rusty Lynch wrote:
> On Tue, Feb 10, 2004 at 04:07:26PM -0800, Villalovos, John L wrote:
> > Just did a sync with revision 30 from the repository.
> >
> > It fails to insmod.
> >
> > /lib/modules/2.4.22-1.2149.nptl/unsupported/fs/ocfs2.o: unresolved
> > symbol OCFS_SB_GET_KDEV
> >
> > It looks like the latest revision removed the definition of
> > OCFS_SB_GET_KDEV in src/inc/ocfs.h but is still using the macro :(
>
> Here is a fix
Thanks, committed to the tree.
-Manish
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-02-10 19:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-10 18:07 [Ocfs2-devel] Revision 30 fails to insmod Villalovos, John L
2004-02-10 18:28 ` Rusty Lynch
2004-02-10 19:10 ` Manish Singh
-- strict thread matches above, loose matches on Subject: below --
2004-02-10 18:36 Villalovos, John L
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.