From: Ernst Herzberg <earny@net4u.de>
To: linux-kernel@vger.kernel.org
Cc: Peter Osterlund <petero2@telia.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: Linux 2.6.3-rc3
Date: Sun, 15 Feb 2004 22:52:17 +0100 [thread overview]
Message-ID: <200402152252.17301.earny@net4u.de> (raw)
In-Reply-To: <m28yj42jcm.fsf@p4.localdomain>
On Sonntag, 15. Februar 2004 21:11, Peter Osterlund wrote:
> Ernst Herzberg <earny@net4u.de> writes:
> > Compile warnings with new driver:
> >
> > [...]
> > drivers/video/aty/radeon_base.c: In function
> > `radeon_probe_pll_params': drivers/video/aty/radeon_base.c:474:
> > warning: `xtal' might be used uninitialized in this function
>
> This looks like a real bug. I guess the patch below fixes it, but I
> can't test it because that code is not executed on my hardware. (And I
> doubt it will fix your problem.)
>
> --- linux/drivers/video/aty/radeon_base.c.old 2004-02-15
> 21:06:02.000000000 +0100 +++
> linux/drivers/video/aty/radeon_base.c 2004-02-15 20:57:22.000000000
> +0100 @@ -566,8 +566,9 @@
> break;
> }
>
> - do_div(vclk, 1000);
> - xtal = (xtal * denom) / num;
> + vclk *= denom;
> + do_div(vclk, 1000 * num);
> + xtal = vclk;
>
> if ((xtal > 26900) && (xtal < 27100))
> xtal = 2700;
>
> > drivers/video/aty/radeon_base.c: In function `radeon_screen_blank':
> > drivers/video/aty/radeon_base.c:944: warning: `val2' might be used
> > uninitialized in this function drivers/video/aty/radeon_base.c: In
> > function `radeonfb_setcolreg': drivers/video/aty/radeon_base.c:1025:
> > warning: `vclk_cntl' might be used uninitialized in this function CC
> > net/sunrpc/timer.o
> > drivers/video/aty/radeon_base.c: In function `radeon_calc_pll_regs':
> > drivers/video/aty/radeon_base.c:1319: warning: `pll_output_freq' might
> > be used uninitialized in this function
>
> I think these warnings are harmless.
This patch does not help, the console is still blank. The monitor shows:
H. Freq 63.98 kHz
V. Freq 60.00 HZ
Pixel Clock 107.98 Mhz
Resolution 1280x1024
Belinea101705
.. but with a black screen...
~Earny
next prev parent reply other threads:[~2004-02-15 21:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-15 3:33 Linux 2.6.3-rc3 Linus Torvalds
2004-02-15 7:41 ` 2.6.3-rc3: twice defined symbols with new radeonfb Adrian Bunk
2004-02-15 7:47 ` Benjamin Herrenschmidt
2004-02-15 13:22 ` Adrian Bunk
2004-02-15 19:19 ` Roman Zippel
2004-02-15 9:17 ` Linux 2.6.3-rc3 Peter Osterlund
2004-02-15 9:54 ` Benjamin Herrenschmidt
2004-02-15 10:25 ` Benjamin Herrenschmidt
2004-02-15 10:51 ` Peter Osterlund
2004-02-15 11:11 ` Benjamin Herrenschmidt
2004-02-15 11:21 ` Geert Uytterhoeven
2004-02-15 10:33 ` Peter Osterlund
2004-02-15 15:03 ` Jonathan Brown
2004-02-15 16:05 ` Tomas Szepe
2004-02-15 16:44 ` Onur Kucuk
2004-02-16 15:58 ` Moritz Muehlenhoff
2004-02-17 16:29 ` Moritz Muehlenhoff
2004-02-15 19:52 ` Ernst Herzberg
2004-02-15 20:11 ` Peter Osterlund
2004-02-15 21:52 ` Ernst Herzberg [this message]
2004-02-15 22:29 ` Benjamin Herrenschmidt
[not found] ` <200402152357.25751.earny@net4u.de>
2004-02-15 23:08 ` Benjamin Herrenschmidt
[not found] ` <200402160033.43438.earny@net4u.de>
2004-02-15 23:54 ` Benjamin Herrenschmidt
2004-02-16 0:29 ` Ernst Herzberg
2004-02-16 0:38 ` Ernst Herzberg
2004-02-16 0:43 ` Benjamin Herrenschmidt
2004-02-16 1:18 ` Ernst Herzberg
2004-02-16 1:47 ` Benjamin Herrenschmidt
2004-02-16 0:41 ` Benjamin Herrenschmidt
[not found] ` <124101c3f435$9a66d3a0$1225a8c0@kittycat>
2004-02-16 2:37 ` Benjamin Herrenschmidt
2004-02-15 22:27 ` Benjamin Herrenschmidt
[not found] ` <200402160005.47892.anib@uni-paderborn.de>
2004-02-15 23:11 ` Benjamin Herrenschmidt
2004-02-16 19:18 ` Linux 2.6.3-rc3 (compile stats) John Cherry
-- strict thread matches above, loose matches on Subject: below --
2004-02-16 6:15 Linux 2.6.3-rc3 Jonathan Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402152252.17301.earny@net4u.de \
--to=earny@net4u.de \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petero2@telia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.