From: greg@kroah.com (Greg KH)
To: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Cc: sensors@stimpy.netroedge.com
Subject: 2.6.3rc4 ali1535 i2c driver rmmod oops.
Date: Thu, 19 May 2005 06:24:42 +0000 [thread overview]
Message-ID: <20040218040153.GB6729@kroah.com> (raw)
In-Reply-To: <20040218031544.GB26304@redhat.com>
On Wed, Feb 18, 2004 at 03:15:44AM +0000, Dave Jones wrote:
> Erk, whats going on here ?
Hm, I'll try to debug this tomorrow.
Oh nevermind, that's just a dumb driver. It's doing a release_region on
memory it didn't get. Stupid, stupid, stupid...
Dave can you verify that this patch fixes the problem for you?
thanks,
greg k-h
=== i2c-ali1535.c 1.12 vs edited ==--- 1.12/drivers/i2c/busses/i2c-ali1535.c Tue Jan 20 08:58:03 2004
+++ edited/i2c-ali1535.c Tue Feb 17 20:00:44 2004
@@ -517,6 +517,7 @@
static void __devexit ali1535_remove(struct pci_dev *dev)
{
i2c_del_adapter(&ali1535_adapter);
+ release_region(ali1535_smba, ALI1535_SMB_IOSIZE);
}
static struct pci_driver ali1535_driver = {
@@ -534,7 +535,6 @@
static void __exit i2c_ali1535_exit(void)
{
pci_unregister_driver(&ali1535_driver);
- release_region(ali1535_smba, ALI1535_SMB_IOSIZE);
}
MODULE_AUTHOR("Frodo Looijaard <frodol@dds.nl>, "
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Cc: sensors@stimpy.netroedge.com
Subject: Re: 2.6.3rc4 ali1535 i2c driver rmmod oops.
Date: Tue, 17 Feb 2004 20:01:54 -0800 [thread overview]
Message-ID: <20040218040153.GB6729@kroah.com> (raw)
In-Reply-To: <20040218031544.GB26304@redhat.com>
On Wed, Feb 18, 2004 at 03:15:44AM +0000, Dave Jones wrote:
> Erk, whats going on here ?
Hm, I'll try to debug this tomorrow.
Oh nevermind, that's just a dumb driver. It's doing a release_region on
memory it didn't get. Stupid, stupid, stupid...
Dave can you verify that this patch fixes the problem for you?
thanks,
greg k-h
===== i2c-ali1535.c 1.12 vs edited =====
--- 1.12/drivers/i2c/busses/i2c-ali1535.c Tue Jan 20 08:58:03 2004
+++ edited/i2c-ali1535.c Tue Feb 17 20:00:44 2004
@@ -517,6 +517,7 @@
static void __devexit ali1535_remove(struct pci_dev *dev)
{
i2c_del_adapter(&ali1535_adapter);
+ release_region(ali1535_smba, ALI1535_SMB_IOSIZE);
}
static struct pci_driver ali1535_driver = {
@@ -534,7 +535,6 @@
static void __exit i2c_ali1535_exit(void)
{
pci_unregister_driver(&ali1535_driver);
- release_region(ali1535_smba, ALI1535_SMB_IOSIZE);
}
MODULE_AUTHOR("Frodo Looijaard <frodol@dds.nl>, "
next prev parent reply other threads:[~2005-05-19 6:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-18 3:15 2.6.3rc4 ali1535 i2c driver rmmod oops Dave Jones
2004-02-18 3:47 ` Linus Torvalds
2004-02-18 3:49 ` Dave Jones
2004-02-18 4:00 ` Linus Torvalds
2004-02-18 4:02 ` Dave Jones
2004-02-18 4:34 ` viro
2004-02-18 4:01 ` Greg KH [this message]
2005-05-19 6:24 ` Greg KH
2004-02-18 4:17 ` Dave Jones
2005-05-19 6:24 ` Dave Jones
2004-02-21 7:19 ` Jean Delvare
2005-05-19 6:24 ` Jean Delvare
2004-02-24 0:27 ` Greg KH
2005-05-19 6:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040218040153.GB6729@kroah.com \
--to=greg@kroah.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.