From: Jens Axboe <axboe@suse.de>
To: Frank Pieczynski <pieczy@web.de>
Cc: Kai Makisara <Kai.Makisara@kolumbus.fi>,
Joachim Feise <jfeise@ics.uci.edu>,
linux-scsi@vger.kernel.org, Michael Guntsche <mike@it-loops.com>,
Andrew Morton <akpm@osdl.org>,
"Justin T. Gibbs" <gibbs@scsiguy.com>
Subject: Re: PROBLEM: 2.6.3 hangs when writing to scsi-dvd
Date: Mon, 23 Feb 2004 20:05:36 +0100 [thread overview]
Message-ID: <20040223190536.GN32010@suse.de> (raw)
In-Reply-To: <200402231921.33895.pieczy@web.de>
On Mon, Feb 23 2004, Frank Pieczynski wrote:
> On Monday 23 February 2004 15:25, Jens Axboe wrote:
> > > > > I hope someone sees no where the real problem is.
> > > >
> > > > SCSI io completion path (sr/sd/st rw_intr() -> scsi_io_completion() ->
> > > > scsi_end_request()) doesn't properly handle non-sector aligned data
> > > > transfers. This patch should fix it up. Warning: untested.
> > >
> > > Now it is slightly tested: it works with my SCSI tape test program. Since
> > > the program only does an inquiry, I tried it with the SCSI system disk
> > > without problems. Unfortunately, I don't have access to a SCSI CDROM now.
> >
> > Great, that's promising (code like this tends to either break at first
> > access, or work :-). Thanks for testing.
>
> Hello all,
> yes, this fix works! I can open k3b now without problems.
> And yes, my other SCSI devices are still working, also my SATA disks using
> libata.
> Thank you ver much,
Andrew, care to shake it down in -mm for a release? IMO it's clearly the
way to go (changing io completion to be byte based instead of sectors),
and the patch looks ok to me (well obviously :-)
--
Jens Axboe
next prev parent reply other threads:[~2004-02-23 19:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-19 19:47 PROBLEM: 2.6.3 hangs when writing to scsi-dvd Joachim Feise
2004-02-20 22:13 ` Joachim Feise
2004-02-23 11:52 ` Kai Makisara
2004-02-23 13:26 ` Jens Axboe
2004-02-23 14:22 ` Kai Makisara
2004-02-23 14:25 ` Jens Axboe
2004-02-23 18:21 ` Frank Pieczynski
2004-02-23 19:05 ` Jens Axboe [this message]
2004-02-24 7:18 ` Joachim Feise
2004-02-23 13:46 ` mike
-- strict thread matches above, loose matches on Subject: below --
2004-02-21 10:25 Michael Guntsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040223190536.GN32010@suse.de \
--to=axboe@suse.de \
--cc=Kai.Makisara@kolumbus.fi \
--cc=akpm@osdl.org \
--cc=gibbs@scsiguy.com \
--cc=jfeise@ics.uci.edu \
--cc=linux-scsi@vger.kernel.org \
--cc=mike@it-loops.com \
--cc=pieczy@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.