From: Pavel Machek <pavel-AlSwsSmVLrQ@public.gmane.org>
To: Bruno Ducrot <ducrot-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
Cc: Rusty trivial patch monkey Russell
<trivial-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>,
Andrew Morton <akpm-LJ1TwQYPT6cQrrorzV6ljw@public.gmane.org>,
kernel list
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Stefan Seyfried <seife-l3A5Bk7waGM@public.gmane.org>,
acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: swsusp/s3: Assembly interactions need asmlinkage
Date: Wed, 25 Feb 2004 11:11:00 +0100 [thread overview]
Message-ID: <20040225101100.GA214@elf.ucw.cz> (raw)
In-Reply-To: <20040225083957.GE2869-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
Hi!
> > swsusp/s3 assembly parts, and parts called from assembly are not
> > properly marked asmlinkage; that leads to double fault on resume when
> > someone compiles kernel with regparm. Thanks go to Stefan Seyfried for
> > discovering this. Please apply,
>
> Does acpi_enter_sleep_state_s4bios() have the same issue ?
Yes, it does; I missed that. Thanks. Here's the fix.
Pavel
--- clean/drivers/acpi/hardware/hwsleep.c 2004-02-05 01:53:59.000000000 +0100
+++ linux/drivers/acpi/hardware/hwsleep.c 2004-02-25 11:08:15.000000000 +0100
@@ -359,7 +359,7 @@
*
******************************************************************************/
-acpi_status
+acpi_status asmlinkage
acpi_enter_sleep_state_s4bios (
void)
{
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@suse.cz>
To: Bruno Ducrot <ducrot@poupinou.org>
Cc: Rusty trivial patch monkey Russell <trivial@rustcorp.com.au>,
Andrew Morton <akpm@zip.com.au>,
kernel list <linux-kernel@vger.kernel.org>,
Stefan Seyfried <seife@suse.de>,
acpi-devel@lists.sourceforge.net
Subject: Re: [ACPI] swsusp/s3: Assembly interactions need asmlinkage
Date: Wed, 25 Feb 2004 11:11:00 +0100 [thread overview]
Message-ID: <20040225101100.GA214@elf.ucw.cz> (raw)
In-Reply-To: <20040225083957.GE2869@poupinou.org>
Hi!
> > swsusp/s3 assembly parts, and parts called from assembly are not
> > properly marked asmlinkage; that leads to double fault on resume when
> > someone compiles kernel with regparm. Thanks go to Stefan Seyfried for
> > discovering this. Please apply,
>
> Does acpi_enter_sleep_state_s4bios() have the same issue ?
Yes, it does; I missed that. Thanks. Here's the fix.
Pavel
--- clean/drivers/acpi/hardware/hwsleep.c 2004-02-05 01:53:59.000000000 +0100
+++ linux/drivers/acpi/hardware/hwsleep.c 2004-02-25 11:08:15.000000000 +0100
@@ -359,7 +359,7 @@
*
******************************************************************************/
-acpi_status
+acpi_status asmlinkage
acpi_enter_sleep_state_s4bios (
void)
{
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2004-02-25 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-24 13:00 swsusp/s3: Assembly interactions need asmlinkage Pavel Machek
2004-02-24 13:00 ` Pavel Machek
[not found] ` <20040224130051.GA8964-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2004-02-25 8:39 ` Bruno Ducrot
2004-02-25 8:39 ` [ACPI] " Bruno Ducrot
[not found] ` <20040225083957.GE2869-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
2004-02-25 10:11 ` Pavel Machek [this message]
2004-02-25 10:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040225101100.GA214@elf.ucw.cz \
--to=pavel-alswssmvlrq@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=akpm-LJ1TwQYPT6cQrrorzV6ljw@public.gmane.org \
--cc=ducrot-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=seife-l3A5Bk7waGM@public.gmane.org \
--cc=trivial-8n+1lVoiYb80n/F98K4Iww@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.