[uml-devel] missed_ticks (2.6)

[uml-devel] missed_ticks (2.6)

[Pete Zaitcev]

Hi,

I was looking at the way timer works on UML and noticed that missed_ticks
is not actually used for anything. Is there a plan for it? If not, maybe
we should drop it.

Cheers,
-- Pete

diff -ur -X dontdiff linux-2.6.3-rc2-uml-1/arch/um/kernel/skas/trap_user.c linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/skas/trap_user.c
--- linux-2.6.3-rc2-uml-1/arch/um/kernel/skas/trap_user.c	2004-02-15 21:26:30.000000000 -0800
+++ linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/skas/trap_user.c	2004-02-29 18:48:11.000000000 -0800
@@ -35,8 +35,6 @@
 	errno = save_errno;
 }
 
-extern int missed_ticks[];
-
 void user_signal(int sig, union uml_pt_regs *regs)
 {
 	struct signal_info *info;
diff -ur -X dontdiff linux-2.6.3-rc2-uml-1/arch/um/kernel/time_kern.c linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/time_kern.c
--- linux-2.6.3-rc2-uml-1/arch/um/kernel/time_kern.c	2004-02-15 21:26:31.000000000 -0800
+++ linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/time_kern.c	2004-02-29 19:02:44.000000000 -0800
@@ -41,12 +41,6 @@
 /* Changed at early boot */
 int timer_irq_inited = 0;
 
-/* missed_ticks will be modified after kernel memory has been 
- * write-protected, so this puts it in a section which will be left 
- * write-enabled.
- */
-int __attribute__ ((__section__ (".unprotected"))) missed_ticks[NR_CPUS];
-
 static int first_tick;
 static unsigned long long prev_tsc;
 static long long delta;   		/* Deviation per interval */
diff -ur -X dontdiff linux-2.6.3-rc2-uml-1/arch/um/kernel/trap_user.c linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/trap_user.c
--- linux-2.6.3-rc2-uml-1/arch/um/kernel/trap_user.c	2004-02-15 21:26:31.000000000 -0800
+++ linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/trap_user.c	2004-02-29 19:02:28.000000000 -0800
@@ -102,12 +102,11 @@
 			 sig, &sc);
 }
 
-extern int timer_irq_inited, missed_ticks[];
+extern int timer_irq_inited;
 
 void alarm_handler(int sig, struct sigcontext sc)
 {
 	if(!timer_irq_inited) return;
-	missed_ticks[cpu()]++;
 
 	if(sig == SIGALRM)
 		switch_timers(0);


-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] missed_ticks (2.6)

[Jeff Dike]

On Sun, Feb 29, 2004 at 07:19:32PM -0800, Pete Zaitcev wrote:
> I was looking at the way timer works on UML and noticed that missed_ticks
> is not actually used for anything. Is there a plan for it? If not, maybe
> we should drop it.

Thanks, I just hadn't got around to cleaning that up.

				Jeff


-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] missed_ticks (2.6)

[Jeff Dike]

On Sun, Feb 29, 2004 at 07:19:32PM -0800, Pete Zaitcev wrote:
> I was looking at the way timer works on UML and noticed that missed_ticks
> is not actually used for anything. Is there a plan for it? If not, maybe
> we should drop it.

Applied, thanks.

		Jeff


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel