All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][2.6] Fixed ISA configuration
@ 2004-03-02 10:50 Yoichi Yuasa
  2004-03-02 12:50 ` Ralf Baechle
  0 siblings, 1 reply; 3+ messages in thread
From: Yoichi Yuasa @ 2004-03-02 10:50 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: yuasa, linux-mips

Hi Ralf,

This patch solves the problem which cannot choose ISA support about CASIO E55, IBM WorkPad, and others.
Please apply this patch to v2.6.

Yoichi

diff -urN -X dontdiff linux-orig/arch/mips/Kconfig linux/arch/mips/Kconfig
--- linux-orig/arch/mips/Kconfig	2004-02-26 10:39:17.000000000 +0900
+++ linux/arch/mips/Kconfig	2004-03-02 11:35:24.000000000 +0900
@@ -1317,8 +1317,7 @@
 
 config ISA
 	bool "ISA bus support"
-	depends on ACER_PICA_61 || SGI_IP22 || MIPS_MAGNUM_4000 || OLIVETTI_M700 || SNI_RM200_PCI
-	default y if TOSHIBA_RBTX4927 || DDB5476 || DDB5074 || IBM_WORKPAD || CASIO_E55
+	depends on ACER_PICA_61 || SGI_IP22 || MIPS_MAGNUM_4000 || OLIVETTI_M700 || SNI_RM200_PCI || TOSHIBA_RBTX4927 || DDB5476 || DDB5074 || IBM_WORKPAD || CASIO_E55
 	help
 	  Find out whether you have ISA slots on your motherboard.  ISA is the
 	  name of a bus system, i.e. the way the CPU talks to the other stuff

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][2.6] Fixed ISA configuration
  2004-03-02 10:50 [PATCH][2.6] Fixed ISA configuration Yoichi Yuasa
@ 2004-03-02 12:50 ` Ralf Baechle
  2004-03-02 14:26   ` Yoichi Yuasa
  0 siblings, 1 reply; 3+ messages in thread
From: Ralf Baechle @ 2004-03-02 12:50 UTC (permalink / raw)
  To: Yoichi Yuasa; +Cc: linux-mips

On Tue, Mar 02, 2004 at 07:50:28PM +0900, Yoichi Yuasa wrote:

> This patch solves the problem which cannot choose ISA support about CASIO E55, IBM WorkPad, and others.
> Please apply this patch to v2.6.

I've choosen to fix this a different way.  I don't think it's a good idea
to require users to know if they need to enable CONFIG_ISA or not because
the question isn't equivalent to having ISA slots or not, so there's
potencial for missconfiguration.  So my alternative patch which I checked
now uses reverse dependencies to eleminate the long depends line of the
config ISA block and only enable ISA where really necessary.

  Ralf

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][2.6] Fixed ISA configuration
  2004-03-02 12:50 ` Ralf Baechle
@ 2004-03-02 14:26   ` Yoichi Yuasa
  0 siblings, 0 replies; 3+ messages in thread
From: Yoichi Yuasa @ 2004-03-02 14:26 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: yuasa, linux-mips

Hi Ralf,

On Tue, 2 Mar 2004 13:50:34 +0100
Ralf Baechle <ralf@linux-mips.org> wrote:

> On Tue, Mar 02, 2004 at 07:50:28PM +0900, Yoichi Yuasa wrote:
> 
> > This patch solves the problem which cannot choose ISA support about CASIO E55, IBM WorkPad, and others.
> > Please apply this patch to v2.6.
> 
> I've choosen to fix this a different way.  I don't think it's a good idea
> to require users to know if they need to enable CONFIG_ISA or not because
> the question isn't equivalent to having ISA slots or not, so there's
> potencial for missconfiguration.  So my alternative patch which I checked
> now uses reverse dependencies to eleminate the long depends line of the
> config ISA block and only enable ISA where really necessary.

Ok, I don't have a problem about it.

Thanks,

Yoichi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-03-02 14:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-02 10:50 [PATCH][2.6] Fixed ISA configuration Yoichi Yuasa
2004-03-02 12:50 ` Ralf Baechle
2004-03-02 14:26   ` Yoichi Yuasa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.