Re: powernow-k8-acpi driver

[Pavel Machek <pavel@suse.cz>]

Hi!

>  > We could make that functionality depend on CONFIG_ACPI, and allow
>  > runtime selection only if its defined... But those two drivers are
>  > pretty different just now and acpi-dependend chunk is pretty big. (It
>  > does funny stuff like polling for AC plug removal if we are in
>  > high-power state  and battery would not handle that. Old driver simply
>  > refused to use high-power states on such machines.)
> 
> you're aware of Dominik/Bruno's work on the 'acpilib'[1] stuff in this
> area right ? We'll need that anyway for Powernow-k7 and maybe longhaul too
> and its senseless duplicating this code.
> 
> One thing is bugging me though. Whats wrong with the ACPI P-state cpufreq
> driver ? Does that not work these days ? It's been a long time since I
> even looked at it.

One more thing: is there any reason for "use-array-as-struct"?

static int query_current_values_with_pending_wait(u8 *perproc)
{
...
        perproc[PP_OFF_CVID] = hi & MSR_S_HI_CURRENT_VID;
        perproc[PP_OFF_CFID] = lo & MSR_S_LO_CURRENT_FID;
}

having 

struct cpu_power {
	int numps, share, cvid, cfid;
	char pstates[0];
}

should do the trick...
							Pavel

-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]