All of lore.kernel.org
 help / color / mirror / Atom feed
From: renzo@cs.unibo.it (Renzo Davoli)
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Progress
Date: Mon, 15 Mar 2004 09:48:41 +0100	[thread overview]
Message-ID: <20040315084841.GA10528@cs.unibo.it> (raw)
In-Reply-To: <4054D5E3.8080509@bellard.org>

On Sun, Mar 14, 2004 at 11:00:03PM +0100, Fabrice Bellard wrote:
> - multiple network interface support (untested)

I have found a minor bug about this:
the management of the -tun-fd option (changed to cope with multiple
interfaces) is buggy, it is a for(;;) loop with no exiting break.

The fix is very simple:
*** vl.c.orig   Mon Mar 15 09:43:50 2004
--- vl.c        Mon Mar 15 09:39:15 2004
***************
*** 980,986 ****
                          } else if (*p != '\0') {
                              fprintf(stderr, "qemu: invalid fd for
network interface %d\n", nb_nics);
                              exit(1);
!                         }
                      }
                  }
                break;
--- 980,987 ----
                          } else if (*p != '\0') {
                              fprintf(stderr, "qemu: invalid fd for
network interface %d\n", nb_nics);
                              exit(1);
!                         } else
!                               break;
                      }
                  }
                break;

  parent reply	other threads:[~2004-03-15  8:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-03 20:23 [Qemu-devel] qemu floppy stress : memtest+ Sebastien Bechet
2004-03-08 12:15 ` Sebastien Bechet
2004-03-08 13:48 ` Jocelyn Mayer
2004-03-14 22:00   ` [Qemu-devel] Progress Fabrice Bellard
2004-03-14 22:45     ` Kyle Hayes
2004-03-15 22:34       ` J. Mayer
2004-03-15  0:24     ` Chad Page
2004-03-15  0:25     ` ignore: " Chad Page
2004-03-15  8:48     ` Renzo Davoli [this message]
2004-03-15 23:52       ` Fabrice Bellard
  -- strict thread matches above, loose matches on Subject: below --
2004-03-16 14:19 Yelich, Scott D.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040315084841.GA10528@cs.unibo.it \
    --to=renzo@cs.unibo.it \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.