From: Dave Jones <davej@redhat.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] tcic kj audit
Date: Wed, 17 Mar 2004 00:02:25 +0000 [thread overview]
Message-ID: <20040317000225.GF24623@redhat.com> (raw)
In-Reply-To: <405764AD.6070905@gentoo.org>
On Tue, Mar 16, 2004 at 08:33:49PM +0000, Chuck Short wrote:
> @@ -337,7 +337,7 @@ static int __init is_active(int s)
>
> if ((sstat & TCIC_SSTAT_CD) && (pwr & TCIC_PWR_VCC(s)) &&
> (scf1 & TCIC_SCF1_IOSTS) && (ioctl & TCIC_ICTL_ENA) &&
> - (check_region(base, num) != 0) && ((base & 0xfeef) != 0x02e8))
> + (region_request(base, num) != 0) && ((base & 0xfeef) != 0x02e8))
> return 1;
> else
> return 0;
I guess you didn't even compile test this one ?
You'll also need to release the region at some point.
check_region fixes aren't just a simple search & replace.
Dave
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-03-17 0:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-16 20:33 [Kernel-janitors] tcic kj audit Chuck Short
2004-03-17 0:02 ` Dave Jones [this message]
2004-03-18 23:28 ` Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040317000225.GF24623@redhat.com \
--to=davej@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.