From: Chuck Short <zul@gentoo.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] tcic kj audit
Date: Tue, 16 Mar 2004 20:33:49 +0000 [thread overview]
Message-ID: <405764AD.6070905@gentoo.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 92 bytes --]
Hi,
This patch changes char* into char[] and add's KERN_* to some printks to
tcic.
chuck
[-- Attachment #2: tcic-kj-audit.patch --]
[-- Type: text/plain, Size: 1584 bytes --]
--- linux-2.6.4.orig/drivers/pcmcia/tcic.c 2004-03-11 02:55:28.000000000 +0000
+++ linux-2.6.4/drivers/pcmcia/tcic.c 2004-03-16 16:24:56.000000000 +0000
@@ -58,7 +58,7 @@
#ifdef PCMCIA_DEBUG
static int pc_debug = PCMCIA_DEBUG;
MODULE_PARM(pc_debug, "i");
-static const char *version =
+static const char version[] =
"tcic.c 1.111 2000/02/15 04:13:12 (David Hinds)";
#define DEBUG(n, args...) if (pc_debug>(n)) printk(KERN_DEBUG args)
#else
@@ -337,7 +337,7 @@ static int __init is_active(int s)
if ((sstat & TCIC_SSTAT_CD) && (pwr & TCIC_PWR_VCC(s)) &&
(scf1 & TCIC_SCF1_IOSTS) && (ioctl & TCIC_ICTL_ENA) &&
- (check_region(base, num) != 0) && ((base & 0xfeef) != 0x02e8))
+ (region_request(base, num) != 0) && ((base & 0xfeef) != 0x02e8))
return 1;
else
return 0;
@@ -403,7 +403,7 @@ static int __init init_tcic(void)
sock = 0;
if (!request_region(tcic_base, 16, "tcic-2")) {
- printk("could not allocate ports,\n ");
+ printk(KERN_INFO "could not allocate ports,\n ");
driver_unregister(&tcic_driver);
return -ENODEV;
}
@@ -505,11 +505,11 @@ static int __init init_tcic(void)
}
if (socket_table[0].socket.irq_mask & (1 << 11))
- printk("sktirq is irq 11, ");
+ printk(KERN_INFO "sktirq is irq 11, ");
if (cs_irq != 0)
- printk("status change on irq %d\n", cs_irq);
+ printk(KERN_NOTICE "status change on irq %d\n", cs_irq);
else
- printk("polled status, interval = %d ms\n",
+ printk(KERN_INFO "polled status, interval = %d ms\n",
poll_interval * 1000 / HZ);
for (i = 0; i < sockets; i++) {
[-- Attachment #3: Type: text/plain, Size: 163 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2004-03-16 20:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-16 20:33 Chuck Short [this message]
2004-03-17 0:02 ` [Kernel-janitors] tcic kj audit Dave Jones
2004-03-18 23:28 ` Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=405764AD.6070905@gentoo.org \
--to=zul@gentoo.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.