Re: powernow-k8, more updates

[Bruno Ducrot <ducrot@poupinou.org>]

On Wed, Mar 17, 2004 at 01:04:09PM +0100, Pavel Machek wrote:
> Hi!
> 
> [Cc-ed cpufreq list again]
> 
> Here are few typo fixes [I believe they are applicable to dominik's
> latest version]; I cleaned up puinfo_x86 stuff in check_supported_cpu
> (no ifdefs any more!) and introduced fill_powernow_table helper. It
> makes code nicer, and makes overriding tables way easier (and you get
> all the normal checks for your overrident table, so its harder to mess
> it up). Notice that values are now for my arima (1.8GHz), and I
> basically guessed them, Paul might have better values. Oh and I now
> print out frequencies to the user, so that dmesg output is
> informative.
> 
>  
>  #if 0
> + override:
>          /*
>  	 * hack for machines without a PSB - as an example values for
> -	 * 2.0/1.8/0.8 GHz are hardcoded. You need to assert that these
> +	 * 1.8/1.6/0.8 GHz are hardcoded. You need to assert that these
>  	 * values are correct and supported by your CPU / motherboard
> +	 *
...
> -	data->powernow_table = powernow_table;
> -
> -	return 0;
>  #endif

Why not just provide an override from userspace?


-- 
Bruno Ducrot

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.