From: Pavel Machek <pavel@ucw.cz>
To: paul.devriendt@amd.com, Cpufreq mailing list <cpufreq@www.linux.org.uk>
Subject: Re: powernow-k8, more updates
Date: Wed, 17 Mar 2004 20:50:15 +0100 [thread overview]
Message-ID: <20040317195015.GA287@elf.ucw.cz> (raw)
In-Reply-To: <20040317124432.GA7426@dominikbrodowski.de>
Hi!
> On Wed, Mar 17, 2004 at 01:04:09PM +0100, Pavel Machek wrote:
> > - * (C) 2003 Dave Jones <davej@codemonkey.ork.uk> on behalf of SuSE Labs
> > + * (C) 2003 Dave Jones <davej@codemonkey.org.uk> on behalf of SuSE Labs
>
> either I'm blind or stupid... what's the difference here?
Blind. Original email address has .ork. in it.
> > + printk(KERN_INFO PFX " %d : fid %x (%d MHz), vid %x\n", j,
> > + pst[j].fid, powernow_table[j].frequency/1000, pst[j].vid);
>
> > +
> > + printk(KERN_INFO PFX "cfid %x, cvid %x\n", data->currfid, data->currvid);
>
> can we change this to dprintk, please? It avoids some noise....
I agree about the second one. I thought that list of frequencies in
MHz is probably important enough?
> Other than that, patch looks good to me
Should I edit it and resend?
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2004-03-17 19:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <99F2150714F93F448942F9A9F112634C1126A014@txexmtae.amd.com>
[not found] ` <20040317100745.GA15284@dominikbrodowski.de>
2004-03-17 12:04 ` powernow-k8, more updates Pavel Machek
2004-03-17 12:44 ` Dominik Brodowski
2004-03-17 13:50 ` Mattia Dongili
2004-03-17 19:50 ` Pavel Machek [this message]
2004-03-17 20:25 ` Dominik Brodowski
2004-03-18 22:33 ` Pavel Machek
2004-03-19 12:43 ` Bruno Ducrot
2004-03-17 16:04 ` Bruno Ducrot
2004-03-17 19:52 ` Pavel Machek
2004-03-17 20:00 paul.devriendt
-- strict thread matches above, loose matches on Subject: below --
2004-03-18 18:51 paul.devriendt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040317195015.GA287@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=cpufreq@www.linux.org.uk \
--cc=paul.devriendt@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.