[Kernel-janitors] [PATCH] 81 patches for strings

[Kernel-janitors] [PATCH] 81 patches for strings

[Carlo Perassi]

Hi.
With some scripting and manual check, I patched 81 files
from
[const] char *foo = "blah";
to
[const] char foo[] = "blah";
(this change makes one variable insted of two variables in the final
assembly output; see line 385 of the TODO file)

I don't attach all the patch files.
A tarball of 81 patch files is here:
http://www.linux.it/~carlo/somehacks/tkp/char81.tar.gz
The text file patches are here:
http://www.linux.it/~carlo/somehacks/tkp/char/
the patch files are in different folders like:
patches_arch/
patches_drivers/
patches_fs/
patches_lib/
patches_net/
patches_sound/

-- 
Carlo Perassi - http://www.linux.it/~carlo/
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH] 81 patches for strings

[Luiz Fernando Capitulino]

Hi Carlo,

Em Sex, 2004-03-19 às 12:06, Carlo Perassi escreveu:
> Hi.
> With some scripting and manual check, I patched 81 files
> from
> [const] char *foo = "blah";
> to
> [const] char foo[] = "blah";

 what about check the result with the size program ?

 a script can do that...

-- 
Luiz Fernando N. Capitulino
<lcapitulino@prefeitura.sp.gov.br>
<http://www.telecentros.sp.gov.br>


_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH] 81 patches for strings

[Domen Puncer]

On Friday 19 of March 2004 16:06, Carlo Perassi wrote:
> Hi.
> With some scripting and manual check, I patched 81 files

Too much scripting maybe?
From patches_arch/file2WYyJB:
--- old/arch/arm/mm/mm-armv.c	2004-03-19 15:05:55.000000000 +0100
+++ new/arch/arm/mm/mm-armv.c	2004-03-19 15:04:42.000000000 +0100
@@ -103,14 +103,14 @@
 
 static void __init early_nocache(char **__unused)
 {
-	char *p = "buffered";
+	char *p[] = "buffered";


gcc would detect this. (ok, arch is not a nice example for compile test, but 
you get the point)


	Domen

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH] 81 patches for strings

[Carlo Perassi]

> you get the point)

Yes: the whole thing was made in two hours and there will be anyway a
lot of reviews.

-- 
Carlo Perassi - http://www.linux.it/~carlo/
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH] 81 patches for strings

[Adrian Bunk]

On Fri, Mar 19, 2004 at 06:29:23PM +0100, Carlo Perassi wrote:
> > you get the point)
> 
> Yes: the whole thing was made in two hours and there will be anyway a
> lot of reviews.

It's better to review patches _before_ sending them the first time.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH] 81 patches for strings

[Carlo Perassi]

> It's better to review patches _before_ sending them the first time.

The review is made before by me and after by others.

-- 
Carlo Perassi - http://www.linux.it/~carlo/
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH] 81 patches for strings

[maximilian attems]

On Sun, 21 Mar 2004, Carlo Perassi wrote:

> > It's better to review patches _before_ sending them the first time.
> 
> The review is made before by me and after by others.

please the next time, compile those modules. 
add an size output for this kind of patches.
it's an good argument :)

thx,
maks

ps.  well so we've got a nice list of potential substitutions
of string forms:

 arch/arm/mm/mm-armv.c                                      |    4 ++--
 arch/i386/kernel/apm.c                                     |    2 +-
 arch/ia64/sn/io/sn2/klconflib.c                            |    2 +-
 arch/ia64/sn/io/sn2/pcibr/pcibr_dvr.c                      |    2 +-
 arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c |    2 +-
 arch/ppc/boot/openfirmware/start.c                         |    2 +-
 arch/ppc/boot/simple/misc-embedded.c                       |    2 +-
 arch/ppc/platforms/chrp_setup.c                            |    2 +-
 arch/ppc/syslib/prom_init.c                                |    2 +-
 arch/ppc64/kernel/chrp_setup.c                             |    2 +-
 arch/ppc64/kernel/lparcfg.c                                |    4 ++--
 arch/ppc64/kernel/prom.c                                   |    2 +-
 arch/sh/kernel/kgdb_stub.c                                 |    2 +-
 arch/sparc/prom/tree.c                                     |    2 +-
 arch/sparc64/kernel/cpu.c                                  |    4 ++--
 arch/x86_64/ia32/sys_ia32.c                                |    2 +-
 arch/x86_64/kernel/e820.c                                  |    2 +-
 arch/x86_64/kernel/traps.c                                 |    2 +-
 drivers/acpi/battery.c                                     |    6 +++---
 drivers/acpi/utilities/utglobal.c                          |    2 +-
 drivers/atm/idt77252.c                                     |    2 +-
 drivers/char/agp/intel-agp.c                               |    2 +-
 drivers/char/lp.c                                          |    2 +-
 drivers/char/nvram.c                                       |    2 +-
 drivers/i2c/chips/adm1021.c                                |    2 +-
 drivers/i2c/chips/it87.c                                   |    2 +-
 drivers/i2c/chips/lm75.c                                   |    2 +-
 drivers/i2c/chips/lm78.c                                   |    2 +-
 drivers/i2c/chips/lm83.c                                   |    2 +-
 drivers/i2c/chips/lm85.c                                   |    2 +-
 drivers/i2c/chips/lm90.c                                   |    2 +-
 drivers/i2c/chips/w83627hf.c                               |    2 +-
 drivers/i2c/chips/w83781d.c                                |    4 ++--
 drivers/ide/legacy/hd.c                                    |    2 +-
 drivers/isdn/hardware/eicon/diva_didd.c                    |    2 +-
 drivers/isdn/hardware/eicon/divamnt.c                      |    2 +-
 drivers/isdn/hardware/eicon/divasi.c                       |    2 +-
 drivers/isdn/hardware/eicon/divasmain.c                    |    2 +-
 drivers/message/fusion/mptbase.c                           |    2 +-
 drivers/message/fusion/mptscsih.c                          |    2 +-
 drivers/mtd/maps/epxa10db-flash.c                          |    2 +-
 drivers/net/3c59x.c                                        |    2 +-
 drivers/net/arm/ether3.c                                   |    2 +-
 drivers/net/ioc3-eth.c                                     |    2 +-
 drivers/net/ne2.c                                          |    2 +-
 drivers/net/pcmcia/fmvj18x_cs.c                            |    2 +-
 drivers/net/tokenring/smctr.c                              |    2 +-
 drivers/parisc/dino.c                                      |    2 +-
 drivers/parport/parport_pc.c                               |    4 ++--
 drivers/pci/hotplug/pciehp_ctrl.c                          |    2 +-
 drivers/pci/hotplug/pciehp_pci.c                           |    2 +-
 drivers/pci/hotplug/shpchp_ctrl.c                          |    2 +-
 drivers/pci/hotplug/shpchp_pci.c                           |    2 +-
 drivers/pnp/pnpbios/rsparser.c                             |    2 +-
 drivers/s390/cio/cmf.c                                     |    2 +-
 drivers/s390/net/iucv.c                                    |    2 +-
 drivers/sbus/char/bbc_envctrl.c                            |    2 +-
 drivers/scsi/aic7xxx_old.c                                 |    2 +-
 drivers/scsi/aic7xxx_old/aic7xxx_proc.c                    |    4 ++--
 drivers/scsi/ini9100u.c                                    |    4 ++--
 drivers/scsi/inia100.c                                     |    4 ++--
 drivers/serial/suncore.c                                   |    6 +++---
 drivers/usb/host/ehci-dbg.c                                |    2 +-
 drivers/usb/host/ohci-dbg.c                                |    2 +-
 drivers/usb/misc/usbtest.c                                 |    2 +-
 drivers/usb/serial/ftdi_sio.c                              |    2 +-
 drivers/video/console/promcon.c                            |    2 +-
 fs/binfmt_misc.c                                           |    2 +-
 fs/partitions/acorn.c                                      |    2 +-
 fs/smbfs/proc.c                                            |    2 +-
 lib/bitmap.c                                               |    2 +-
 net/sunrpc/svcauth_unix.c                                  |    2 +-
 sound/drivers/opl3/opl3_midi.c                             |    2 +-
 sound/isa/wavefront/wavefront_synth.c                      |    2 +-
 sound/oss/cmpci.c                                          |    2 +-
 sound/oss/gus_wave.c                                       |    2 +-
 sound/oss/msnd_pinnacle.c                                  |    2 +-
 sound/oss/wavfront.c                                       |    2 +-
 sound/pci/cs46xx/dsp_spos.c                                |    2 +-
 sound/pci/trident/trident_main.c                           |    2 +-
 80 files changed, 92 insertions(+), 92 deletions(-)
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH] 81 patches for strings

[Randy.Dunlap]

On Mon, 29 Mar 2004 18:53:55 +0200 maximilian attems wrote:

| On Sun, 21 Mar 2004, Carlo Perassi wrote:
| 
| > > It's better to review patches _before_ sending them the first time.
| > 
| > The review is made before by me and after by others.
| 
| please the next time, compile those modules. 

Absolutely!!

| add an size output for this kind of patches.
| it's an good argument :)

Yes, that does help.

| thx,
| maks
| 
| ps.  well so we've got a nice list of potential substitutions
| of string forms:

--
~Randy
"We have met the enemy and he is us."  -- Pogo (by Walt Kelly)
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH] 81 patches for strings

[Randy.Dunlap]

On Fri, 19 Mar 2004 17:54:39 +0100 Domen Puncer wrote:

| On Friday 19 of March 2004 16:06, Carlo Perassi wrote:
| > Hi.
| > With some scripting and manual check, I patched 81 files
| 
| Too much scripting maybe?

or too little?


| >From patches_arch/file2WYyJB:
| --- old/arch/arm/mm/mm-armv.c	2004-03-19 15:05:55.000000000 +0100
| +++ new/arch/arm/mm/mm-armv.c	2004-03-19 15:04:42.000000000 +0100
| @@ -103,14 +103,14 @@
|  
|  static void __init early_nocache(char **__unused)
|  {
| -	char *p = "buffered";
| +	char *p[] = "buffered";

argh.  All 80 or 81 files have this problem!!!

| gcc would detect this. (ok, arch is not a nice example for compile test, but 
| you get the point)

Carlo, if you care to fix these up and resend them, go for it....

--
~Randy
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH] 81 patches for strings

[Carlo Perassi]

> Carlo, if you care to fix these up and resend them, go for it....

I will. My apologies.

-- 
Carlo Perassi - http://www.linux.it/~carlo/
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors