* Re: [PATCH] ISDN Eicon driver: restructured capi list and lock handling [not found] <200403211807.i2LI7e2O004808@hera.kernel.org> @ 2004-03-22 16:01 ` Arjan van de Ven 2004-03-22 16:33 ` Arjan van de Ven 0 siblings, 1 reply; 3+ messages in thread From: Arjan van de Ven @ 2004-03-22 16:01 UTC (permalink / raw) To: Linux Kernel Mailing List; +Cc: armin [-- Attachment #1: Type: text/plain, Size: 627 bytes --] On Sun, 2004-03-21 at 17:55, Linux Kernel Mailing List wrote: > ChangeSet 1.1828, 2004/03/21 08:55:24-08:00, armin@melware.de > > [PATCH] ISDN Eicon driver: restructured capi list and lock handling > > Restructered the CAPI code of list handling and lock. > > Removed obsolete code. this patch is broken: Error: ./drivers/isdn/hardware/eicon/capifunc.o .altinstructions refers to 00000018 R_386_32 .exit.text Error: ./drivers/isdn/hardware/eicon/capifunc.o .init.text refers to 0000015d R_386_PC32 .exit.text eg you call __exit functions from __init functions, which is incorrect.... [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ISDN Eicon driver: restructured capi list and lock handling 2004-03-22 16:01 ` [PATCH] ISDN Eicon driver: restructured capi list and lock handling Arjan van de Ven @ 2004-03-22 16:33 ` Arjan van de Ven 2004-03-22 16:51 ` Armin Schindler 0 siblings, 1 reply; 3+ messages in thread From: Arjan van de Ven @ 2004-03-22 16:33 UTC (permalink / raw) To: Linux Kernel Mailing List; +Cc: armin On Mon, Mar 22, 2004 at 05:32:42PM +0100, Arjan van de Ven wrote: > On Sun, 2004-03-21 at 17:55, Linux Kernel Mailing List wrote: > > ChangeSet 1.1828, 2004/03/21 08:55:24-08:00, armin@melware.de > > > > [PATCH] ISDN Eicon driver: restructured capi list and lock handling > > > > Restructered the CAPI code of list handling and lock. > > > > Removed obsolete code. > > this patch is broken: > Error: ./drivers/isdn/hardware/eicon/capifunc.o .altinstructions refers > to 00000018 R_386_32 .exit.text > Error: ./drivers/isdn/hardware/eicon/capifunc.o .init.text refers to > 0000015d R_386_PC32 .exit.text > > eg you call __exit functions from __init functions, which is > incorrect.... and the fix: --- linux-2.6.4/drivers/isdn/hardware/eicon/capifunc.c~ 2004-03-22 17:12:30.868043408 +0100 +++ linux-2.6.4/drivers/isdn/hardware/eicon/capifunc.c 2004-03-22 17:12:30.868043408 +0100 @@ -455,7 +455,7 @@ /* * remove cards */ -static void DIVA_EXIT_FUNCTION divacapi_remove_cards(void) +static void divacapi_remove_cards(void) { DESCRIPTOR d; struct list_head *tmp; ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ISDN Eicon driver: restructured capi list and lock handling 2004-03-22 16:33 ` Arjan van de Ven @ 2004-03-22 16:51 ` Armin Schindler 0 siblings, 0 replies; 3+ messages in thread From: Armin Schindler @ 2004-03-22 16:51 UTC (permalink / raw) To: Arjan van de Ven; +Cc: Linux Kernel Mailing List On Mon, 22 Mar 2004, Arjan van de Ven wrote: > > On Mon, Mar 22, 2004 at 05:32:42PM +0100, Arjan van de Ven wrote: > > On Sun, 2004-03-21 at 17:55, Linux Kernel Mailing List wrote: > > > ChangeSet 1.1828, 2004/03/21 08:55:24-08:00, armin@melware.de > > > > > > [PATCH] ISDN Eicon driver: restructured capi list and lock handling > > > > > > Restructered the CAPI code of list handling and lock. > > > > > > Removed obsolete code. > > > > this patch is broken: > > Error: ./drivers/isdn/hardware/eicon/capifunc.o .altinstructions refers > > to 00000018 R_386_32 .exit.text > > Error: ./drivers/isdn/hardware/eicon/capifunc.o .init.text refers to > > 0000015d R_386_PC32 .exit.text > > > > eg you call __exit functions from __init functions, which is > > incorrect.... > > and the fix: > > --- linux-2.6.4/drivers/isdn/hardware/eicon/capifunc.c~ 2004-03-22 17:12:30.868043408 +0100 > +++ linux-2.6.4/drivers/isdn/hardware/eicon/capifunc.c 2004-03-22 17:12:30.868043408 +0100 > @@ -455,7 +455,7 @@ > /* > * remove cards > */ > -static void DIVA_EXIT_FUNCTION divacapi_remove_cards(void) > +static void divacapi_remove_cards(void) > { > DESCRIPTOR d; > struct list_head *tmp; > Yes, you are correct. I wonder why my compiler didn't complain about this. It works here and I don't know why. What configuration did you use? I will create a correct incremental patch (another patch for this file is already send to Linus) for Linus/Andrew. Thanks for pointing out. Armin ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-03-22 17:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200403211807.i2LI7e2O004808@hera.kernel.org>
2004-03-22 16:01 ` [PATCH] ISDN Eicon driver: restructured capi list and lock handling Arjan van de Ven
2004-03-22 16:33 ` Arjan van de Ven
2004-03-22 16:51 ` Armin Schindler
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.