[Ocfs2-devel] [PATCH]Fix for 2.6 unmount crash

[Ocfs2-devel] [PATCH]Fix for 2.6 unmount crash

[Rusty Lynch]

This patch catches the scenario where a dismount has already
been started, and a ocfs_release_cached_oin() has been kicked
off as a result of ocfs_inode_hash_destroy() calling iput()
on any remaining inodes.

http://oss.oracle.com/bugzilla/show_bug.cgi?id=47

This will cause a 2.6 system built with memory debugging to 
crash (indicating that we are doing something wrong, which is using
our cache objects after we have free'ed them.)

I haven't seen a crash on 2.4 due to this, but a 2.4 system does
come across this scenario (but it just doesn't crash.)

    --rusty

Index: src/oin.c
===================================================================
--- src/oin.c	(revision 787)
+++ src/oin.c	(working copy)
@@ -705,6 +705,17 @@
 	if (oin == NULL)
 		goto bail;
 
+	/*
+	 * If the OCFS_OSB_FLAGS_BEING_DISMOUNTED flag has
+	 * already been set, then the lockres hash has already
+	 * been cleaned out which means that we have a lock_res
+	 * pointer that points to free memory.
+	 */
+	if (osb->osb_flags & OCFS_OSB_FLAGS_BEING_DISMOUNTED) {
+		oin->lock_res = NULL;
+		goto bail;
+	}
+
 	ocfs_down_sem (&(oin->main_res), true);
 	bAcquiredOIN = true;
         inode = oin->inode;

[Ocfs2-devel] Re: [PATCH]Fix for 2.6 unmount crash

[Mark Fasheh]

On Thu, Mar 18, 2004 at 08:14:22AM -0800, Rusty Lynch wrote:
> This patch catches the scenario where a dismount has already
> been started, and a ocfs_release_cached_oin() has been kicked
> off as a result of ocfs_inode_hash_destroy() calling iput()
> on any remaining inodes.
It took me a few days, but this is in there now.
	--Mark

--
Mark Fasheh
Software Developer, Oracle Corp
mark.fasheh@oracle.com