From: Phil Oester <kernel@linuxace.com>
To: netfilter-devel@lists.netfilter.org
Subject: [PATCH] Fix LIST_INSERT breakage
Date: Tue, 23 Mar 2004 17:02:30 -0800 [thread overview]
Message-ID: <20040324010230.GA4144@linuxace.com> (raw)
In 2.4.25, this patch was included:
http://linux.bkbits.net:8080/linux-2.4/cset@3fcc5cc99cChx6Q0shnhIlekWT1-5Q?nav=index.html|ChangeSet@-4M
which has a questionable change in LIST_INSERT due to the disappearing
cmpfn. But it appears this macro is unused anywhere in the tree, so perhaps
removing it is better than fixing it?
Phil Oester
--- include/linux/netfilter_ipv4/listhelp.h-orig 2004-03-23 19:57:00.696775216 -0500
+++ include/linux/netfilter_ipv4/listhelp.h 2004-03-23 20:01:09.603032216 -0500
@@ -89,17 +89,6 @@
list_add(new, head);
}
-/* Insert according to ordering function; insert before first true. */
-#define LIST_INSERT(head, new, cmpfn) \
-do { \
- struct list_head *__i; \
- ASSERT_WRITE_LOCK(head); \
- list_for_each(__i, (head)) \
- if ((new), (typeof (new))__i) \
- break; \
- list_add((struct list_head *)(new), __i->prev); \
-} while(0)
-
/* If the field after the list_head is a nul-terminated string, you
can use these functions. */
static inline int __list_cmp_name(const void *i, const char *name)
next reply other threads:[~2004-03-24 1:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-24 1:02 Phil Oester [this message]
2004-03-28 18:40 ` [PATCH] Fix LIST_INSERT breakage Harald Welte
2004-03-28 23:36 ` Phil Oester
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040324010230.GA4144@linuxace.com \
--to=kernel@linuxace.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.