From: Phil Oester <kernel@linuxace.com>
To: Harald Welte <laforge@netfilter.org>,
netfilter-devel@lists.netfilter.org,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Subject: Re: [PATCH] Fix LIST_INSERT breakage
Date: Sun, 28 Mar 2004 15:36:58 -0800 [thread overview]
Message-ID: <20040328233658.GA23295@linuxace.com> (raw)
In-Reply-To: <20040328184053.GY7039@sunbeam.de.gnumonks.org>
LIST_INSERT takes a 'cmpfn' argument, and is used pre-change:
- for (__i = (head)->next; \
- !cmpfn((new), (typeof (new))__i) && __i != (head); \
- __i = __i->next); \
but not post-change:
+ list_for_each(__i, (head)) \
+ if ((new), (typeof (new))__i) \ <---
+ break; \
'if (cmpfn((new), ......' is probably what was intended?
But either way, it is unused and thus moot.
Phil
On Sun, Mar 28, 2004 at 08:40:54PM +0200, Harald Welte wrote:
> On Tue, Mar 23, 2004 at 05:02:30PM -0800, Phil Oester wrote:
> > In 2.4.25, this patch was included:
> >
> > http://linux.bkbits.net:8080/linux-2.4/cset@3fcc5cc99cChx6Q0shnhIlekWT1-5Q?nav=index.html|ChangeSet@-4M
> >
> > which has a questionable change in LIST_INSERT due to the disappearing
> > cmpfn.
>
> Could you be more specific about your objections against that changeset?
prev parent reply other threads:[~2004-03-28 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-24 1:02 [PATCH] Fix LIST_INSERT breakage Phil Oester
2004-03-28 18:40 ` Harald Welte
2004-03-28 23:36 ` Phil Oester [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040328233658.GA23295@linuxace.com \
--to=kernel@linuxace.com \
--cc=kadlec@blackhole.kfki.hu \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.