[Ocfs2-devel] [PATCH]Enable 2.6 file data flushing

[Ocfs2-devel] [PATCH]Enable 2.6 file data flushing

[Rusty Lynch]

The following small patch makes a 2.6 built kernel flush it's 
data buffers to disk on ocfs_sync_inode, fixing bug #46

http://oss.oracle.com/bugzilla/show_bug.cgi?id=46

    --rusty

Index: src/file.c
===================================================================
--- src/file.c	(revision 807)
+++ src/file.c	(working copy)
@@ -68,6 +68,7 @@
 {
 	int status;
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)
+	filemap_fdatawrite(inode->i_mapping);	
 	status = sync_mapping_buffers(inode->i_mapping);
 #else
 	status = fsync_inode_buffers(inode);

[Ocfs2-devel] [PATCH]Enable 2.6 file data flushing

[Wim Coekaerts]

hmm now I wonder if we dont' also need that in 2.4...


On Tue, Mar 23, 2004 at 08:11:53PM -0800, Rusty Lynch wrote:
> The following small patch makes a 2.6 built kernel flush it's 
> data buffers to disk on ocfs_sync_inode, fixing bug #46
> 
> http://oss.oracle.com/bugzilla/show_bug.cgi?id=46
> 
>     --rusty
> 
> Index: src/file.c
> ===================================================================
> --- src/file.c	(revision 807)
> +++ src/file.c	(working copy)
> @@ -68,6 +68,7 @@
>  {
>  	int status;
>  #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)
> +	filemap_fdatawrite(inode->i_mapping);	
>  	status = sync_mapping_buffers(inode->i_mapping);
>  #else
>  	status = fsync_inode_buffers(inode);
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel@oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel

[Ocfs2-devel] [PATCH]Enable 2.6 file data flushing

[Rusty Lynch]

On Tue, Mar 23, 2004 at 08:23:06PM -0800, Wim Coekaerts wrote:
> hmm now I wonder if we dont' also need that in 2.4...
> 
> 
> On Tue, Mar 23, 2004 at 08:11:53PM -0800, Rusty Lynch wrote:
> > The following small patch makes a 2.6 built kernel flush it's 
> > data buffers to disk on ocfs_sync_inode, fixing bug #46
> > 
> > http://oss.oracle.com/bugzilla/show_bug.cgi?id=46
> > 
> >     --rusty
> > 

the equivilant call in 2.4 would be filemap_fdatasync().  I gave it a 
try and it does fix the mmap issue talked about in bug #50.

Here is a patch


Index: src/file.c
===================================================================
--- src/file.c	(revision 807)
+++ src/file.c	(working copy)
@@ -68,8 +68,10 @@
 {
 	int status;
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)
+	filemap_fdatawrite(inode->i_mapping);
 	status = sync_mapping_buffers(inode->i_mapping);
 #else
+	filemap_fdatasync(inode->i_mapping);
 	status = fsync_inode_buffers(inode);
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,18)
 	if (!status)	       

[Ocfs2-devel] [PATCH]Enable 2.6 file data flushing

[Wim Coekaerts]

slick, yeah when I saw your patch I checked in 2.4 and saw it existed as
that, totally makes sense, we should put it in our ocfs1 tree also, I
think that wills olve some of the weirdness we have seen

cool stuff Rusty :)

On Tue, Mar 23, 2004 at 09:58:57PM -0800, Rusty Lynch wrote:
> On Tue, Mar 23, 2004 at 08:23:06PM -0800, Wim Coekaerts wrote:
> > hmm now I wonder if we dont' also need that in 2.4...
> > 
> > 
> > On Tue, Mar 23, 2004 at 08:11:53PM -0800, Rusty Lynch wrote:
> > > The following small patch makes a 2.6 built kernel flush it's 
> > > data buffers to disk on ocfs_sync_inode, fixing bug #46
> > > 
> > > http://oss.oracle.com/bugzilla/show_bug.cgi?id=46
> > > 
> > >     --rusty
> > > 
> 
> the equivilant call in 2.4 would be filemap_fdatasync().  I gave it a 
> try and it does fix the mmap issue talked about in bug #50.
> 
> Here is a patch
> 
> 
> Index: src/file.c
> ===================================================================
> --- src/file.c	(revision 807)
> +++ src/file.c	(working copy)
> @@ -68,8 +68,10 @@
>  {
>  	int status;
>  #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)
> +	filemap_fdatawrite(inode->i_mapping);
>  	status = sync_mapping_buffers(inode->i_mapping);
>  #else
> +	filemap_fdatasync(inode->i_mapping);
>  	status = fsync_inode_buffers(inode);
>  #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,18)
>  	if (!status)	       

[Ocfs2-devel] [PATCH]Enable 2.6 file data flushing

[Mark Fasheh]

On Tue, Mar 23, 2004 at 09:58:57PM -0800, Rusty Lynch wrote:
> the equivilant call in 2.4 would be filemap_fdatasync().  I gave it a 
> try and it does fix the mmap issue talked about in bug #50.
Ok, excellent. I verified that this bug does indeed exist, and the patch
seems to fix it. I'll put it in SVN today. Nice catch Rusty!
	--Mark

--
Mark Fasheh
Software Developer, Oracle Corp
mark.fasheh@oracle.com