Re: [PATCH] 1/3 - RPC metrics support

[Greg Banks <gnb@sgi.com>]

On Thu, Apr 01, 2004 at 08:45:40AM -0800, Lever, Charles wrote:
> > The minor dimension of the 2d array of struct 
> > rpc_metrics_totals pointed to by rpc_tally is per-CPU.  To 
> > get correct per-CPU separation you will want to 
> > cacheline-align the per-CPU parts (so that cachelines which 
> > straddle the per-CPU parts don't end up bouncing between 
> > CPUs).  For example, in rpc_alloc_tally(),
> > 
> > size = NR_CPUS * ROUNDUP(ops * sizeof(struct 
> > rpc_metric_totals), L1_CACHE_BYTES);
> > 
> > and change the stride of the tl_totals[] initialisation loop.
> 
> that doesn't work, unfortunately, unless sizeof(struct rpc_tally)
> is also an exact multiple of L1_CACHE_BYTES.  otherwise the whole
> metrics array starts on a non-cache-aligned boundary since these
> are all cut from the same piece of memory.

That's right, you'll need to add ____cacheline_aligned like this:

struct rpc_tally {
} ____cacheline_aligned;

Greg.
-- 
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs