Re: [PATCH] 1/3 - RPC metrics support

[Greg Banks <gnb@melbourne.sgi.com>]

Trond Myklebust wrote:
> 
> On Thu, 2004-04-01 at 19:49, Greg Banks wrote:
> 
> > Why not just save a copy of @devname in nfs_get_sb() ? 
> 
> That is very different. That we can do...
> 
> Please don't confuse the export path and the device name. nfss->mnt_path
> is the former: 

> The device name OTOH is just whatever label the caller of sys_mount()
> feels like passing down to the kernel. It will usually contain the name
> of the server and the export path ('cos that's what the nfs-utils
> "mount" does), but it does not have to, and we currently do not depend
> on it taking any particular value.

If all we care about is identifying the sb for purposes of iostat and
post-mortem debugging (I for one would find this useful), the precise
semantics placed on the string by the mount program don't matter that
much.  You could add a `devname' field to nfs_server and document
that it doesn't mean anything at all.  Alternatively you could check
that the first part matches (modulo domain names) the `hostname' field
and is followed by a ':' and a path, and if all that matches, save the
path.

Greg.
-- 
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs