From: Greg KH <greg@kroah.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: bashizm in hotplug scripts (including 20040401)
Date: Mon, 05 Apr 2004 17:11:22 +0000 [thread overview]
Message-ID: <20040405171122.GA7287@kroah.com> (raw)
In-Reply-To: <200404020211.45303.arekm@pld-linux.org>
On Mon, Apr 05, 2004 at 04:06:15PM +1000, Martin Schwenke wrote:
> >>>>> "Arkadiusz" = Arkadiusz Miskiewicz <arekm@pld-linux.org> writes:
>
> Arkadiusz> So hotplug scripts still need the change because they
> Arkadiusz> do arithmetic beyond signed long:
>
> Arkadiusz> [...]$ grep -r 0xffffffff .
> Arkadiusz> ./etc/hotplug/pci.agent:PCI_ANY=$((0xffffffff))
>
> The value of PCI_ANY only ever compared against other things - there's
> no useful arithmetic done. The PCI 2.2 specification only allows
> Vendor ID and Device ID to be 16 bits (in configuration space at
> least). If there any reason for using the value 0xffffffff, rather
> than just 0xffff? Greg?
Look at include/linux/mod_devicetable.h for why that is a 32 bit number
(needs to match up with the pci_device_id fields.)
Now why those fields are 32 bits, you will probably have to go dig
through the 2.3 kernel archives, I don't remember anymore.
thanks,
greg k-h
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2004-04-05 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-02 0:11 bashizm in hotplug scripts (including 20040401) Arkadiusz Miskiewicz
2004-04-02 1:09 ` Martin Schwenke
2004-04-02 13:05 ` Arkadiusz Miskiewicz
2004-04-05 6:06 ` Martin Schwenke
2004-04-05 17:11 ` Greg KH [this message]
2004-04-05 17:46 ` Arkadiusz Miskiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040405171122.GA7287@kroah.com \
--to=greg@kroah.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.