Re: bashizm in hotplug scripts (including 20040401)

[Arkadiusz Miskiewicz <arekm@pld-linux.org>]

Dnia Monday 05 of April 2004 08:06, Martin Schwenke napisa³:

> The value of PCI_ANY only ever compared against other things - there's
> no useful arithmetic done.  The PCI 2.2 specification only allows
> Vendor ID and Device ID to be 16 bits (in configuration space at
> least).  If there any reason for using the value 0xffffffff, rather
> than just 0xffff?  Greg?
If 16 bits is max in reality then it seems that we don't have to do anything 
because:

PCI_ANY=$((0xffffffff))

would overflow to -1 and 

vendor=$(($vendor));
this will also overflow to -1

if [ $vendor -ne $PCI_ANY -a $vendor -ne $pci_id_vendor ]; then
and we end up with -1 -ne -1 comparsion.

Anyway comment about this should be added in hotplug scripts.

> peace & happiness,
> martin

-- 
Arkadiusz Mi¶kiewicz     CS at FoE, Wroclaw University of Technology
arekm.pld-linux.org, 1024/3DB19BBD, JID: arekm.jabber.org, PLD/Linux


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&opÌk
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel