Re: powernow-k8: support acpi

[Dave Jones <davej@redhat.com>]

On Tue, Apr 06, 2004 at 04:55:02PM +0200, Dominik Brodowski wrote:

 > Just found a small bug which would leave the preempt count negative(!) in
 > special cases. Patch is attached.

good catch. applied.

 > > You can grab what I have in my tree pending pushing to Linus at
 > > http://www.codemonkey.org.uk/projects/cpufreq/pending.diff
 > 
 > Will http://www.codemonkey.org.uk/projects/bitkeeper/cpufreq/
 > be a permanent institution, or is it just available for the moment?

I set it up this morning to do a snapshot each night along with the
other trees one level up from there.  It'll continually keep one weeks
worth of patches.

 > > <f> found a funny bug in the powernow-k8 acpi changes
 > > <f> when  acpi is disabled processor.ko won't load, but the new module needs symbols from that
 > > <f> i added a hack to keep it loaded anyways
 > > 
 > > Be nice to get that fixed, and merged before these changes get pushed to mainline.
 > 
 > Hm. Keeping processor.ko loaded seems to be an ugly hack to me. However, I
 > can't see a way (yet) how powernow-k8.ko can rely on processor.ko's objects
 > but not depend on it if these are not neeeded (psb case).

True, it's a sledgehammer to crack a walnut, but I'm not sure messing with
weak symbols would be any cleaner, and other than that or moving bits out
to a seperate module (double ugh), I don't really have any ideas.

		Dave