* Re: [PATCH] ppc64: create dma_mapping_error
@ 2004-04-02 16:33 James Bottomley
2004-04-07 14:30 ` Anton Blanchard
0 siblings, 1 reply; 2+ messages in thread
From: James Bottomley @ 2004-04-02 16:33 UTC (permalink / raw)
To: Anton Blanchard, Stephen Rothwell, Andrew Morton; +Cc: Linux Kernel
What exactly are you guys doing?
The API Anton introduced: dma_mapping_error() takes only a virtual
address as the argument (no struct device or anyting), so the additional
API's pci_dma_mapping_error() and vio_dma_mapping_error have absolutely
no choice but to do the same thing as dma_mapping_error() (because the
error return cannot be bus or device specific).
So, why bother introducing all these superfluous APIs in the first
place? Just stick to the single dma_mapping_error(); it will be much
easier.
James
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ppc64: create dma_mapping_error
2004-04-02 16:33 [PATCH] ppc64: create dma_mapping_error James Bottomley
@ 2004-04-07 14:30 ` Anton Blanchard
0 siblings, 0 replies; 2+ messages in thread
From: Anton Blanchard @ 2004-04-07 14:30 UTC (permalink / raw)
To: James Bottomley; +Cc: Stephen Rothwell, Andrew Morton, Linux Kernel
> What exactly are you guys doing?
>
> The API Anton introduced: dma_mapping_error() takes only a virtual
> address as the argument (no struct device or anyting), so the additional
> API's pci_dma_mapping_error() and vio_dma_mapping_error have absolutely
> no choice but to do the same thing as dma_mapping_error() (because the
> error return cannot be bus or device specific).
Umm yeah, we should probably just use dma_mapping_error. I want to see
vio_* disappear anyway.
Anton
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-04-07 14:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-02 16:33 [PATCH] ppc64: create dma_mapping_error James Bottomley
2004-04-07 14:30 ` Anton Blanchard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.