All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Kirch <okir@suse.de>
To: nfs@lists.sourceforge.net
Subject: [PATCH] 2.6 open(O_EXCL) sets silly mtime
Date: Tue, 20 Apr 2004 10:18:22 +0200	[thread overview]
Message-ID: <20040420081822.GB14756@suse.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

Hi,

the attached patch (relative to 2.6.5) is required to make sure a file
created with O_EXCL gets the proper mtime.

Olaf
-- 
Olaf Kirch     |  The Hardware Gods hate me.
okir@suse.de   |
---------------+ 

[-- Attachment #2: nfs-o-excl-mtime --]
[-- Type: text/plain, Size: 450 bytes --]

--- linux-2.6.5/fs/nfs/nfs3proc.c.excl	2004-04-19 14:35:47.000000000 +0200
+++ linux-2.6.5/fs/nfs/nfs3proc.c	2004-04-19 16:55:50.000000000 +0200
@@ -375,6 +375,9 @@
 		};
 		dprintk("NFS call  setattr (post-create)\n");
 
+		if (!(sattr->ia_valid & ATTR_MTIME_SET))
+			sattr->ia_valid |= ATTR_MTIME;
+
 		/* Note: we could use a guarded setattr here, but I'm
 		 * not sure this buys us anything (and I'd have
 		 * to revamp the NFSv3 XDR code) */

             reply	other threads:[~2004-04-20  8:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-20  8:18 Olaf Kirch [this message]
2004-04-20 14:47 ` [PATCH] 2.6 open(O_EXCL) sets silly mtime Trond Myklebust
2004-04-21  8:17   ` Olaf Kirch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040420081822.GB14756@suse.de \
    --to=okir@suse.de \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.